From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: vapier@gentoo.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] drivers/char/rtc: disable legacy RTC driver on Blackfin systems
Date: Tue, 26 May 2009 13:30:53 -0700 [thread overview]
Message-ID: <20090526133053.803c2ab8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090526102502.GA24737@infradead.org>
On Tue, 26 May 2009 06:25:02 -0400
Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, May 26, 2009 at 06:10:33AM -0400, Mike Frysinger wrote:
> > tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> > depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > - && !ARM && !SUPERH && !S390 && !AVR32
> > + && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN
>
> Maybe it's better to have a positive dependency for those that actually
> support it these days?
yeah, we do this rather a lot and it's pretty stupid.
> Based on the above list that would be:
>
> depends on ALPHA || CRIS || H8300 || M32R || MICROBLAZE ||
> MIPS || MN10300 || SH || X86 || XTENSA
>
> and I would not be surprised if some of the above don't actually support
> it either..
It would be better to make this driver depend on simply CONFIG_WANT_RTC
or similar and then select CONFIG_WANT_RTC in the relevant
arch/foo/Kconfig files.
prev parent reply other threads:[~2009-05-26 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 10:10 [PATCH] drivers/char/rtc: disable legacy RTC driver on Blackfin systems Mike Frysinger
2009-05-26 10:25 ` Christoph Hellwig
2009-05-26 10:28 ` [rtc-linux] " Mike Frysinger
2009-05-26 11:22 ` Paul Mundt
2009-05-26 20:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526133053.803c2ab8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.