two patches for voicecall.c

two patches for voicecall.c

[Li, Minjun]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi Folks,
I have made 2 patches for minor bugs in functions of voicecall_busy and dial_callback in /src/voicecall.c.
The first one is to use the function pointer set_udub to replace release_specific.
The second one is to delete the repeated calling of voicecall_create in dial_callback function, since it was called in previous line in the same function.

Best Regards,
Minjun


[-- Attachment #2: 0001-Modify-the-function-pointer-in-voicecall_busy-to-set.patch --]
[-- Type: application/octet-stream, Size: 760 bytes --]

From 3229d282264b8ae3f34d437467c6e84cb3d2335a Mon Sep 17 00:00:00 2001
From: Minjun Li <minjun.li@intel.com>
Date: Tue, 26 May 2009 15:28:00 +0800
Subject: [PATCH] Modify the function pointer in voicecall_busy to set_udub

---
 src/voicecall.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/voicecall.c b/src/voicecall.c
index bbc7bf5..73d8889 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -198,7 +198,7 @@ static DBusMessage *voicecall_busy(DBusConnection *conn,
 		call->status != CALL_STATUS_WAITING)
 		return dbus_gsm_failed(msg);
 
-	if (!voicecalls->ops->release_specific)
+	if (!voicecalls->ops->set_udub)
 		return dbus_gsm_not_implemented(msg);
 
 	if (voicecalls->flags & VOICECALLS_FLAG_PENDING)
-- 
1.6.0.3


[-- Attachment #3: 0002-Delete-the-repeated-calling-of-voicecall_creat-funct.patch --]
[-- Type: application/octet-stream, Size: 769 bytes --]

From 9e8f442e14b7aa761e75f7d8f52636c60036626f Mon Sep 17 00:00:00 2001
From: Minjun Li <minjun.li@intel.com>
Date: Tue, 26 May 2009 15:37:22 +0800
Subject: [PATCH] Delete the repeated calling of voicecall_creat function

---
 src/voicecall.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/voicecall.c b/src/voicecall.c
index 73d8889..8318143 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -1444,7 +1444,7 @@ static void dial_callback(const struct ofono_error *error, void *data)
 		}
 
 		ofono_debug("Registering new call: %d", call->id);
-		voicecall_dbus_register(voicecall_create(modem, call));
+		voicecall_dbus_register(v);
 
 		calls->call_list = g_slist_insert_sorted(calls->call_list, v,
 					call_compare);
-- 
1.6.0.3

Re: two patches for voicecall.c

[Leandro Dorileo]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

Hi Minjun

On Wed, May 27, 2009 at 3:46 AM, Li, Minjun <minjun.li@intel.com> wrote:
> Hi Folks,
> I have made 2 patches for minor bugs in functions of voicecall_busy and dial_callback in /src/voicecall.c.
> The first one is to use the function pointer set_udub to replace release_specific.
> The second one is to delete the repeated calling of voicecall_create in dial_callback function, since it was called in previous line in the same function.


I re-read your patch and voicecall.c source code comparing your
changes, your patch seems to be ok, but your log message doesn`t seem
to describe well your changes, your first patch tells in the
subject(file name and so on) you changed the function pointer(on
something not specified) but you changed the verification of it.

Regards...

-- 
(°=   Leandro Dorileo
//\    ldorileo(a)gmail.com   -   http://www.dorilex.net
V_/  Software is a matter of freedom.

Re: two patches for voicecall.c

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi Minjun,

On Wednesday 27 May 2009 02:46:00 Li, Minjun wrote:
> Hi Folks,
> I have made 2 patches for minor bugs in functions of voicecall_busy and
> dial_callback in /src/voicecall.c. The first one is to use the function
> pointer set_udub to replace release_specific. The second one is to delete
> the repeated calling of voicecall_create in dial_callback function, since
> it was called in previous line in the same function.

Both patches have been applied upstream.  Thanks!

Regards,
-Denis