All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, fengguang.wu@intel.com
Subject: [PATCH] [1/16] HWPOISON: Add page flag for poisoned pages
Date: Wed, 27 May 2009 22:12:26 +0200 (CEST)	[thread overview]
Message-ID: <20090527201226.CCCBB1D028F@basil.firstfloor.org> (raw)
In-Reply-To: <200905271012.668777061@firstfloor.org>


Hardware poisoned pages need special handling in the VM and shouldn't be 
touched again. This requires a new page flag. Define it here.

The page flags wars seem to be over, so it shouldn't be a problem
to get a new one.

v2: Add TestSetHWPoison (suggested by Johannes Weiner)

Acked-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 include/linux/page-flags.h |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Index: linux/include/linux/page-flags.h
===================================================================
--- linux.orig/include/linux/page-flags.h	2009-05-27 21:13:54.000000000 +0200
+++ linux/include/linux/page-flags.h	2009-05-27 21:14:21.000000000 +0200
@@ -51,6 +51,9 @@
  * PG_buddy is set to indicate that the page is free and in the buddy system
  * (see mm/page_alloc.c).
  *
+ * PG_hwpoison indicates that a page got corrupted in hardware and contains
+ * data with incorrect ECC bits that triggered a machine check. Accessing is
+ * not safe since it may cause another machine check. Don't touch!
  */
 
 /*
@@ -104,6 +107,9 @@
 #ifdef CONFIG_IA64_UNCACHED_ALLOCATOR
 	PG_uncached,		/* Page has been mapped as uncached */
 #endif
+#ifdef CONFIG_MEMORY_FAILURE
+	PG_hwpoison,		/* hardware poisoned page. Don't touch */
+#endif
 	__NR_PAGEFLAGS,
 
 	/* Filesystems */
@@ -273,6 +279,15 @@
 PAGEFLAG_FALSE(Uncached)
 #endif
 
+#ifdef CONFIG_MEMORY_FAILURE
+PAGEFLAG(HWPoison, hwpoison)
+TESTSETFLAG(HWPoison, hwpoison)
+#define __PG_HWPOISON (1UL << PG_hwpoison)
+#else
+PAGEFLAG_FALSE(HWPoison)
+#define __PG_HWPOISON 0
+#endif
+
 static inline int PageUptodate(struct page *page)
 {
 	int ret = test_bit(PG_uptodate, &(page)->flags);
@@ -403,7 +418,7 @@
 	 1 << PG_private | 1 << PG_private_2 | \
 	 1 << PG_buddy	 | 1 << PG_writeback | 1 << PG_reserved | \
 	 1 << PG_slab	 | 1 << PG_swapcache | 1 << PG_active | \
-	 __PG_UNEVICTABLE | __PG_MLOCKED)
+	 __PG_HWPOISON  | __PG_UNEVICTABLE | __PG_MLOCKED)
 
 /*
  * Flags checked when a page is prepped for return by the page allocator.

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, fengguang.wu@intel.com
Subject: [PATCH] [1/16] HWPOISON: Add page flag for poisoned pages
Date: Wed, 27 May 2009 22:12:26 +0200 (CEST)	[thread overview]
Message-ID: <20090527201226.CCCBB1D028F@basil.firstfloor.org> (raw)
In-Reply-To: <200905271012.668777061@firstfloor.org>


Hardware poisoned pages need special handling in the VM and shouldn't be 
touched again. This requires a new page flag. Define it here.

The page flags wars seem to be over, so it shouldn't be a problem
to get a new one.

v2: Add TestSetHWPoison (suggested by Johannes Weiner)

Acked-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 include/linux/page-flags.h |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Index: linux/include/linux/page-flags.h
===================================================================
--- linux.orig/include/linux/page-flags.h	2009-05-27 21:13:54.000000000 +0200
+++ linux/include/linux/page-flags.h	2009-05-27 21:14:21.000000000 +0200
@@ -51,6 +51,9 @@
  * PG_buddy is set to indicate that the page is free and in the buddy system
  * (see mm/page_alloc.c).
  *
+ * PG_hwpoison indicates that a page got corrupted in hardware and contains
+ * data with incorrect ECC bits that triggered a machine check. Accessing is
+ * not safe since it may cause another machine check. Don't touch!
  */
 
 /*
@@ -104,6 +107,9 @@
 #ifdef CONFIG_IA64_UNCACHED_ALLOCATOR
 	PG_uncached,		/* Page has been mapped as uncached */
 #endif
+#ifdef CONFIG_MEMORY_FAILURE
+	PG_hwpoison,		/* hardware poisoned page. Don't touch */
+#endif
 	__NR_PAGEFLAGS,
 
 	/* Filesystems */
@@ -273,6 +279,15 @@
 PAGEFLAG_FALSE(Uncached)
 #endif
 
+#ifdef CONFIG_MEMORY_FAILURE
+PAGEFLAG(HWPoison, hwpoison)
+TESTSETFLAG(HWPoison, hwpoison)
+#define __PG_HWPOISON (1UL << PG_hwpoison)
+#else
+PAGEFLAG_FALSE(HWPoison)
+#define __PG_HWPOISON 0
+#endif
+
 static inline int PageUptodate(struct page *page)
 {
 	int ret = test_bit(PG_uptodate, &(page)->flags);
@@ -403,7 +418,7 @@
 	 1 << PG_private | 1 << PG_private_2 | \
 	 1 << PG_buddy	 | 1 << PG_writeback | 1 << PG_reserved | \
 	 1 << PG_slab	 | 1 << PG_swapcache | 1 << PG_active | \
-	 __PG_UNEVICTABLE | __PG_MLOCKED)
+	 __PG_HWPOISON  | __PG_UNEVICTABLE | __PG_MLOCKED)
 
 /*
  * Flags checked when a page is prepped for return by the page allocator.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-05-27 20:12 UTC|newest]

Thread overview: 238+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27 20:12 [PATCH] [0/16] HWPOISON: Intro Andi Kleen
2009-05-27 20:12 ` Andi Kleen
2009-05-27 20:12 ` Andi Kleen [this message]
2009-05-27 20:12   ` [PATCH] [1/16] HWPOISON: Add page flag for poisoned pages Andi Kleen
2009-05-27 20:35   ` Larry H.
2009-05-27 20:35     ` Larry H.
2009-05-27 21:15   ` Alan Cox
2009-05-27 21:15     ` Alan Cox
2009-05-28  7:54     ` Andi Kleen
2009-05-28  7:54       ` Andi Kleen
2009-05-29 16:10       ` Rik van Riel
2009-05-29 16:10         ` Rik van Riel
2009-05-29 16:37         ` Andi Kleen
2009-05-29 16:37           ` Andi Kleen
2009-05-29 16:34           ` Rik van Riel
2009-05-29 16:34             ` Rik van Riel
2009-05-29 18:24             ` Andi Kleen
2009-05-29 18:24               ` Andi Kleen
2009-05-29 18:26               ` Rik van Riel
2009-05-29 18:26                 ` Rik van Riel
2009-05-29 18:42                 ` Andi Kleen
2009-05-29 18:42                   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [2/16] HWPOISON: Export poison flag in /proc/kpageflags Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-29 16:37   ` Rik van Riel
2009-05-29 16:37     ` Rik van Riel
2009-05-27 20:12 ` [PATCH] [3/16] HWPOISON: Export some rmap vma locking to outside world Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [4/16] HWPOISON: Add support for poison swap entries v2 Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-28  8:46   ` Hidehiro Kawai
2009-05-28  8:46     ` Hidehiro Kawai
2009-05-28  9:11     ` Wu Fengguang
2009-05-28  9:11       ` Wu Fengguang
2009-05-28 10:42     ` Andi Kleen
2009-05-28 10:42       ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [5/16] HWPOISON: Add new SIGBUS error codes for hardware poison signals Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [6/16] HWPOISON: Add basic support for poisoned pages in fault handler v2 Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-29  4:15   ` Hidehiro Kawai
2009-05-29  4:15     ` Hidehiro Kawai
2009-05-29  6:28     ` Andi Kleen
2009-05-29  6:28       ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [7/16] HWPOISON: Add various poison checks in mm/memory.c Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [8/16] HWPOISON: x86: Add VM_FAULT_HWPOISON handling to x86 page fault handler Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [9/16] HWPOISON: Use bitmask/action code for try_to_unmap behaviour Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-28  7:27   ` Nick Piggin
2009-05-28  7:27     ` Nick Piggin
2009-05-28  8:03     ` Andi Kleen
2009-05-28  8:03       ` Andi Kleen
2009-05-28  8:28       ` Nick Piggin
2009-05-28  8:28         ` Nick Piggin
2009-05-28  9:02         ` Andi Kleen
2009-05-28  9:02           ` Andi Kleen
2009-05-28 12:26           ` Nick Piggin
2009-05-28 12:26             ` Nick Piggin
2009-05-27 20:12 ` [PATCH] [10/16] HWPOISON: Handle hardware poisoned pages in try_to_unmap Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [11/16] HWPOISON: Handle poisoned pages in set_page_dirty() Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [12/16] HWPOISON: check and isolate corrupted free pages Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v3 Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-28  8:26   ` Nick Piggin
2009-05-28  8:26     ` Nick Piggin
2009-05-28  9:31     ` Andi Kleen
2009-05-28  9:31       ` Andi Kleen
2009-05-28 12:08       ` Nick Piggin
2009-05-28 12:08         ` Nick Piggin
2009-05-28 13:45         ` Andi Kleen
2009-05-28 13:45           ` Andi Kleen
2009-05-28 14:50           ` Wu Fengguang
2009-05-28 14:50             ` Wu Fengguang
2009-06-04  6:25             ` Nai Xia
2009-06-04  6:25               ` Nai Xia
2009-06-07 16:02               ` Wu Fengguang
2009-06-07 16:02                 ` Wu Fengguang
2009-06-08 11:06                 ` Nai Xia
2009-06-08 11:06                   ` Nai Xia
2009-06-08 12:31                   ` Wu Fengguang
2009-06-08 12:31                     ` Wu Fengguang
2009-06-08 14:46                     ` Nai Xia
2009-06-08 14:46                       ` Nai Xia
2009-06-09  6:48                       ` Wu Fengguang
2009-06-09  6:48                         ` Wu Fengguang
2009-06-09 10:48                         ` Nick Piggin
2009-06-09 10:48                           ` Nick Piggin
2009-06-09 12:15                           ` Wu Fengguang
2009-06-09 12:15                             ` Wu Fengguang
2009-06-09 12:17                             ` Nick Piggin
2009-06-09 12:17                               ` Nick Piggin
2009-06-09 12:47                               ` Wu Fengguang
2009-06-09 12:47                                 ` Wu Fengguang
2009-06-09 13:36                                 ` Nai Xia
2009-06-09 13:36                                   ` Nai Xia
2009-05-28 16:56           ` Russ Anderson
2009-05-28 16:56             ` Russ Anderson
2009-05-30  6:42             ` Andi Kleen
2009-05-30  6:42               ` Andi Kleen
2009-06-01 11:39               ` Nick Piggin
2009-06-01 11:39                 ` Nick Piggin
2009-06-01 18:19                 ` Andi Kleen
2009-06-01 18:19                   ` Andi Kleen
2009-06-01 12:05           ` Nick Piggin
2009-06-01 12:05             ` Nick Piggin
2009-06-01 18:51             ` Andi Kleen
2009-06-01 18:51               ` Andi Kleen
2009-06-02 12:10               ` Nick Piggin
2009-06-02 12:10                 ` Nick Piggin
2009-06-02 12:34                 ` Andi Kleen
2009-06-02 12:34                   ` Andi Kleen
2009-06-02 12:37                   ` Nick Piggin
2009-06-02 12:37                     ` Nick Piggin
2009-06-02 12:55                     ` Andi Kleen
2009-06-02 12:55                       ` Andi Kleen
2009-06-02 13:03                       ` Nick Piggin
2009-06-02 13:03                         ` Nick Piggin
2009-06-02 13:20                         ` Andi Kleen
2009-06-02 13:20                           ` Andi Kleen
2009-06-02 13:19                           ` Nick Piggin
2009-06-02 13:19                             ` Nick Piggin
2009-06-02 13:46                             ` Andi Kleen
2009-06-02 13:46                               ` Andi Kleen
2009-06-02 13:47                               ` Nick Piggin
2009-06-02 13:47                                 ` Nick Piggin
2009-06-02 14:05                                 ` Andi Kleen
2009-06-02 14:05                                   ` Andi Kleen
2009-06-02 13:30                     ` Wu Fengguang
2009-06-02 13:30                       ` Wu Fengguang
2009-06-02 14:07                       ` Nick Piggin
2009-06-02 14:07                         ` Nick Piggin
2009-05-28  9:59     ` Wu Fengguang
2009-05-28  9:59       ` Wu Fengguang
2009-05-28 10:11       ` Andi Kleen
2009-05-28 10:11         ` Andi Kleen
2009-05-28 10:33         ` Wu Fengguang
2009-05-28 10:33           ` Wu Fengguang
2009-05-28 10:51           ` Andi Kleen
2009-05-28 10:51             ` Andi Kleen
2009-05-28 11:03             ` Wu Fengguang
2009-05-28 11:03               ` Wu Fengguang
2009-05-28 12:15             ` Nick Piggin
2009-05-28 12:15               ` Nick Piggin
2009-05-28 13:48               ` Andi Kleen
2009-05-28 13:48                 ` Andi Kleen
2009-05-28 12:23       ` Nick Piggin
2009-05-28 12:23         ` Nick Piggin
2009-05-28 13:54         ` Wu Fengguang
2009-05-28 13:54           ` Wu Fengguang
2009-06-01 11:50           ` Nick Piggin
2009-06-01 11:50             ` Nick Piggin
2009-06-01 14:05             ` Wu Fengguang
2009-06-01 14:05               ` Wu Fengguang
2009-06-01 14:40               ` Nick Piggin
2009-06-01 14:40                 ` Nick Piggin
2009-06-02 11:14                 ` Wu Fengguang
2009-06-02 11:14                   ` Wu Fengguang
2009-06-02 12:19                   ` Nick Piggin
2009-06-02 12:19                     ` Nick Piggin
2009-06-02 12:51                     ` Wu Fengguang
2009-06-02 12:51                       ` Wu Fengguang
2009-06-02 14:33                       ` Nick Piggin
2009-06-02 14:33                         ` Nick Piggin
2009-06-03 10:21                       ` Jens Axboe
2009-06-03 10:21                         ` Jens Axboe
2009-06-01 21:11               ` Hugh Dickins
2009-06-01 21:11                 ` Hugh Dickins
2009-06-01 21:41                 ` Andi Kleen
2009-06-01 21:41                   ` Andi Kleen
2009-06-01 18:32             ` Andi Kleen
2009-06-01 18:32               ` Andi Kleen
2009-06-02 12:00               ` Nick Piggin
2009-06-02 12:00                 ` Nick Piggin
2009-06-02 12:47                 ` Andi Kleen
2009-06-02 12:47                   ` Andi Kleen
2009-06-02 12:57                   ` Nick Piggin
2009-06-02 12:57                     ` Nick Piggin
2009-06-02 13:25                     ` Andi Kleen
2009-06-02 13:25                       ` Andi Kleen
2009-06-02 13:24                       ` Nick Piggin
2009-06-02 13:24                         ` Nick Piggin
2009-06-02 13:41                         ` Andi Kleen
2009-06-02 13:41                           ` Andi Kleen
2009-06-02 13:40                           ` Nick Piggin
2009-06-02 13:40                             ` Nick Piggin
2009-06-02 13:53                           ` Wu Fengguang
2009-06-02 13:53                             ` Wu Fengguang
2009-06-02 14:06                             ` Andi Kleen
2009-06-02 14:06                               ` Andi Kleen
2009-06-02 14:12                               ` Wu Fengguang
2009-06-02 14:12                                 ` Wu Fengguang
2009-06-02 14:21                                 ` Nick Piggin
2009-06-02 14:21                                   ` Nick Piggin
2009-06-02 13:46                     ` Wu Fengguang
2009-06-02 13:46                       ` Wu Fengguang
2009-06-02 14:08                       ` Andi Kleen
2009-06-02 14:08                         ` Andi Kleen
2009-06-02 14:10                         ` Wu Fengguang
2009-06-02 14:10                           ` Wu Fengguang
2009-06-02 14:14                           ` Nick Piggin
2009-06-02 14:14                             ` Nick Piggin
2009-06-02 15:17                       ` Nick Piggin
2009-06-02 15:17                         ` Nick Piggin
2009-06-02 17:27                         ` Andi Kleen
2009-06-02 17:27                           ` Andi Kleen
2009-06-03  9:35                           ` Nick Piggin
2009-06-03  9:35                             ` Nick Piggin
2009-06-03 11:24                             ` Andi Kleen
2009-06-03 11:24                               ` Andi Kleen
2009-06-02 13:02                   ` Wu Fengguang
2009-06-02 13:02                     ` Wu Fengguang
2009-06-02 15:09                   ` Nick Piggin
2009-06-02 15:09                     ` Nick Piggin
2009-06-02 17:19                     ` Andi Kleen
2009-06-02 17:19                       ` Andi Kleen
2009-06-03  6:24                       ` Nick Piggin
2009-06-03  6:24                         ` Nick Piggin
2009-06-03 15:51               ` Wu Fengguang
2009-06-03 15:51                 ` Wu Fengguang
2009-06-03 16:05                 ` Andi Kleen
2009-06-03 16:05                   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [14/16] HWPOISON: FOR TESTING: Enable memory failure code unconditionally Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [15/16] HWPOISON: Add madvise() based injector for hardware poisoned pages v3 Andi Kleen
2009-05-27 20:12   ` Andi Kleen
2009-05-27 20:12 ` [PATCH] [16/16] HWPOISON: Add simple debugfs interface to inject hwpoison on arbitary PFNs Andi Kleen
2009-05-27 20:12   ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2009-05-29 21:35 [PATCH] [0/16] HWPOISON: Intro Andi Kleen
2009-05-29 21:35 ` [PATCH] [1/16] HWPOISON: Add page flag for poisoned pages Andi Kleen
2009-05-29 21:35   ` Andi Kleen
2009-05-29 21:52   ` Alan Cox
2009-05-29 21:52     ` Alan Cox
2009-06-03 18:46 [PATCH] [0/16] HWPOISON: Intro Andi Kleen
2009-06-03 18:46 ` [PATCH] [1/16] HWPOISON: Add page flag for poisoned pages Andi Kleen
2009-06-03 18:46   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090527201226.CCCBB1D028F@basil.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.