Re: [PATCH 7/9] Set default extN mount options

From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 7/9] Set default extN mount options
Date: Thu, 28 May 2009 06:01:22 -0400	[thread overview]
Message-ID: <20090528100122.GG651@infradead.org> (raw)
In-Reply-To: <1243450413-12681-8-git-send-email-sandeen@sandeen.net>

On Wed, May 27, 2009 at 01:53:31PM -0500, Eric Sandeen wrote:
> ext2/3/4 don't support acls & attrs w/o specific mount
> options, so make those the default whenever we mount
> these filesystems.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>  common.rc |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/common.rc b/common.rc
> index 78514f4..54c36f3 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -49,6 +49,10 @@ _mount_opts()
>      nfs)
>  	export MOUNT_OPTIONS=$NFS_MOUNT_OPTIONS
>  	;;
> +    ext2|ext3|ext4)
> +	# acls & xattrs aren't turned on by default on ext$FOO
> +	export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
> +	;;

This part looks good.

> @@ -585,7 +589,7 @@ _require_scratch()
>  		     _notrun "this test requires a valid \$SCRATCH_DEV"
>  		 fi
>  		 ;;
> -	nfs*|ext2|ext3|reiserfs)
> +	nfs*|ext2|ext3|ext4|reiserfs)
>  		 echo $SCRATCH_DEV | grep -q ":" > /dev/null 2>&1
>  		 if [ ! -z "$SCRATCH_DEV" -a ! -b "$SCRATCH_DEV" -a "$?" != "0" ]

This whole function looks fishy to me, but just treating ext4 the same
as ext2/ext3 makes sense at least.

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs