All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 8/9] Enable generic filesystems to be fsck'd
Date: Thu, 28 May 2009 08:51:28 -0400	[thread overview]
Message-ID: <20090528125128.GA13425@infradead.org> (raw)
In-Reply-To: <1243450413-12681-9-git-send-email-sandeen@sandeen.net>

On Wed, May 27, 2009 at 01:53:32PM -0500, Eric Sandeen wrote:
> This includes a fair bit of rearranging to avoid code duplication,
> but the goal is to allow 'fsck -n -t $FSTYP $device' to be run on
> any generic filesystem.
> 
> Any FS for which this doesn't work will need it's own fsck routine.

Looks generally good, some comments:

 - I would get rid of _check_generic_test_fs and just opencode the
   _check_generic_filesystem $TEST_DEV in the two callers.
 - why the odd calling convention of _is_mounted which allows to
   optionally pass the fstype?  Currently we only have one caller
   that doesn't pass it, and if we grow one that needs it I would
   rather always pass it explicitly..

Btw, I seems like _check_testdir is never actually called, and I can't
really see a reason why it would be different from _check_test_fs.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-05-28 12:51 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27 18:53 [PATCH 0/9] xfstests: more generic fs work Eric Sandeen
2009-05-27 18:53 ` [PATCH 1/9] Use xfs.h rather than libxfs.h Eric Sandeen
2009-05-28  9:56   ` Christoph Hellwig
2009-05-28 15:46     ` [PATCH 0.5/9] Replace MAXNAMELEN with NAME_MAX + 1 Eric Sandeen
2009-05-28 15:48       ` Christoph Hellwig
2009-05-28 16:16     ` [PATCH 1/9 V2] Use xfs.h rather than libxfs.h Eric Sandeen
2009-05-28 16:22       ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 2/9] Make libxfs.h optional Eric Sandeen
2009-05-28  9:57   ` Christoph Hellwig
2009-05-28 14:59     ` Eric Sandeen
2009-05-28 15:35       ` Christoph Hellwig
2009-05-28 16:15         ` Eric Sandeen
2009-05-27 18:53 ` [PATCH 3/9] Support "generic" filesystem type Eric Sandeen
2009-05-28  9:58   ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 4/9] 069: make scratch mkfs quiet Eric Sandeen
2009-05-28  9:58   ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 5/9] Set up testdir for generic filesystems Eric Sandeen
2009-05-28  9:59   ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 6/9] Detect FS type to test based on TEST_DEV Eric Sandeen
2009-05-28  9:59   ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 7/9] Set default extN mount options Eric Sandeen
2009-05-28  9:11   ` Michael Monnerie
2009-05-28 10:02     ` Christoph Hellwig
2009-05-28 10:35       ` Michael Monnerie
2009-05-28 14:56         ` Eric Sandeen
2009-05-29  6:37           ` Michael Monnerie
2009-05-28 10:01   ` Christoph Hellwig
2009-05-28 14:57     ` Eric Sandeen
2009-05-27 18:53 ` [PATCH 8/9] Enable generic filesystems to be fsck'd Eric Sandeen
2009-05-28 12:51   ` Christoph Hellwig [this message]
2009-06-02 12:38     ` Christoph Hellwig
2009-06-02 15:10       ` Eric Sandeen
2009-06-02 17:25         ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 9/9] Report which tests did get run Eric Sandeen
2009-05-28 12:51   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090528125128.GA13425@infradead.org \
    --to=hch@infradead.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.