[PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

[PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

[David Miller]

First of all, it exposes the SKB list implementation.

Second of all it's not needed.  If we get called here, we
successfully enqueued the URB with the linked SKB and
such a completion only gets called one time on such an
SKB.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/wireless/rtl818x/rtl8187_dev.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c b/drivers/net/wireless/rtl818x/rtl8187_dev.c
index 6499ccc..3f22cc0 100644
--- a/drivers/net/wireless/rtl818x/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187_dev.c
@@ -321,12 +321,7 @@ static void rtl8187_rx_cb(struct urb *urb)
 	unsigned long f;
 
 	spin_lock_irqsave(&priv->rx_queue.lock, f);
-	if (skb->next)
-		__skb_unlink(skb, &priv->rx_queue);
-	else {
-		spin_unlock_irqrestore(&priv->rx_queue.lock, f);
-		return;
-	}
+	__skb_unlink(skb, &priv->rx_queue);
 	spin_unlock_irqrestore(&priv->rx_queue.lock, f);
 	skb_put(skb, urb->actual_length);
 
-- 
1.6.3

Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

[John W. Linville]

On Fri, May 29, 2009 at 01:40:11AM -0700, David Miller wrote:
> 
> First of all, it exposes the SKB list implementation.
> 
> Second of all it's not needed.  If we get called here, we
> successfully enqueued the URB with the linked SKB and
> such a completion only gets called one time on such an
> SKB.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>

ACK

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

[John W. Linville]

On Fri, May 29, 2009 at 01:40:11AM -0700, David Miller wrote:
> 
> First of all, it exposes the SKB list implementation.
> 
> Second of all it's not needed.  If we get called here, we
> successfully enqueued the URB with the linked SKB and
> such a completion only gets called one time on such an
> SKB.
> 
> Signed-off-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

ACK

-- 
John W. Linville		Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

[Hin-Tak Leung]

On Fri, May 29, 2009 at 11:18 AM, John W. Linville
<linville@tuxdriver.com> wrote:
> On Fri, May 29, 2009 at 01:40:11AM -0700, David Miller wrote:
>>
>> First of all, it exposes the SKB list implementation.
>>
>> Second of all it's not needed.  If we get called here, we
>> successfully enqueued the URB with the linked SKB and
>> such a completion only gets called one time on such an
>> SKB.
>>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> ACK

ACK.

I'll give this a try when I rebuild the rtl8187 module on my box.

Hin-Tak

Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

[Hin-Tak Leung]

On Fri, May 29, 2009 at 11:18 AM, John W. Linville
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> wrote:
> On Fri, May 29, 2009 at 01:40:11AM -0700, David Miller wrote:
>>
>> First of all, it exposes the SKB list implementation.
>>
>> Second of all it's not needed.  If we get called here, we
>> successfully enqueued the URB with the linked SKB and
>> such a completion only gets called one time on such an
>> SKB.
>>
>> Signed-off-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
>
> ACK

ACK.

I'll give this a try when I rebuild the rtl8187 module on my box.

Hin-Tak
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx_cb().

[David Miller]

From: Hin-Tak Leung <hintak.leung@gmail.com>
Date: Fri, 29 May 2009 16:41:20 +0100

> I'll give this a try when I rebuild the rtl8187 module on my box.

Thank you.