* [PATCH 1/3] ide: remove superfluous SELECT_MASK() call from ide_driveid_update()
@ 2009-06-01 21:52 Bartlomiej Zolnierkiewicz
2009-06-02 15:47 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-06-01 21:52 UTC (permalink / raw)
To: linux-ide; +Cc: Sergei Shtylyov
We always call SELECT_MASK(drive, 0) after ide_dev_read_id() call
so there is no need to do it again in the error path.
Moreover with the combination of HPT36x controller and the drive on
the quirk_drives[] list this can result in superfluous enable_irq()
call which in turn will trigger WARN() in __enable_irq().
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
Sergei, after re-audit of my recent changes: these three patches should go
before "hpt366: sync quirk_drives[] list with pdc202xx_{new,old}.c" one.
drivers/ide/ide-iops.c | 1 -
1 file changed, 1 deletion(-)
Index: b/drivers/ide/ide-iops.c
===================================================================
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-iops.c
@@ -311,7 +311,6 @@ int ide_driveid_update(ide_drive_t *driv
return 1;
out_err:
- SELECT_MASK(drive, 0);
if (rc == 2)
printk(KERN_ERR "%s: %s: bad status\n", drive->name, __func__);
kfree(id);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/3] ide: remove superfluous SELECT_MASK() call from ide_driveid_update()
2009-06-01 21:52 [PATCH 1/3] ide: remove superfluous SELECT_MASK() call from ide_driveid_update() Bartlomiej Zolnierkiewicz
@ 2009-06-02 15:47 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2009-06-02 15:47 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Hello.
Bartlomiej Zolnierkiewicz wrote:
> We always call SELECT_MASK(drive, 0) after ide_dev_read_id() call
> so there is no need to do it again in the error path.
> Moreover with the combination of HPT36x controller and the drive on
> the quirk_drives[] list this can result in superfluous enable_irq()
> call which in turn will trigger WARN() in __enable_irq().
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-02 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-01 21:52 [PATCH 1/3] ide: remove superfluous SELECT_MASK() call from ide_driveid_update() Bartlomiej Zolnierkiewicz
2009-06-02 15:47 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.