* [PATCH 2/3] ide: remove superfluous SELECT_MASK() call from do_rw_taskfile()
@ 2009-06-01 21:53 Bartlomiej Zolnierkiewicz
2009-06-02 16:24 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-06-01 21:53 UTC (permalink / raw)
To: linux-ide; +Cc: Sergei Shtylyov
With ->write_devctl method call (which unmasks drive IRQ) preceding
SELECT_MASK() call there is really no need for the latter.
Moreover with the combination of HPT36x controller and the drive on
the quirk_drives[] list this can result in superfluous enable_irq()
call which in turn will trigger WARN() in __enable_irq().
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-taskfile.c | 1 -
1 file changed, 1 deletion(-)
Index: b/drivers/ide/ide-taskfile.c
===================================================================
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -98,7 +98,6 @@ ide_startstop_t do_rw_taskfile(ide_drive
if ((cmd->tf_flags & IDE_TFLAG_DMA_PIO_FALLBACK) == 0) {
ide_tf_dump(drive->name, cmd);
tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
- SELECT_MASK(drive, 0);
if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) {
u8 data[2] = { cmd->tf.data, cmd->hob.data };
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] ide: remove superfluous SELECT_MASK() call from do_rw_taskfile()
2009-06-01 21:53 [PATCH 2/3] ide: remove superfluous SELECT_MASK() call from do_rw_taskfile() Bartlomiej Zolnierkiewicz
@ 2009-06-02 16:24 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2009-06-02 16:24 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> With ->write_devctl method call (which unmasks drive IRQ) preceding
> SELECT_MASK() call there is really no need for the latter.
> Moreover with the combination of HPT36x controller and the drive on
> the quirk_drives[] list this can result in superfluous enable_irq()
> call which in turn will trigger WARN() in __enable_irq().
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-02 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-01 21:53 [PATCH 2/3] ide: remove superfluous SELECT_MASK() call from do_rw_taskfile() Bartlomiej Zolnierkiewicz
2009-06-02 16:24 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.