* [PATCH] Honor CONFIG_CMDLINE on SiByte
@ 2009-06-02 12:22 Imre Kaloz
2009-06-02 17:59 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Imre Kaloz @ 2009-06-02 12:22 UTC (permalink / raw)
To: linux-mips
The SiByte platform code doesn't honor the CONFIG_CMDLINE kernel
option. This patch fixes this issue.
Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
---
arch/mips/sibyte/common/cfe.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/mips/sibyte/common/cfe.c b/arch/mips/sibyte/common/cfe.c
index 3de30f7..97e997e 100644
--- a/arch/mips/sibyte/common/cfe.c
+++ b/arch/mips/sibyte/common/cfe.c
@@ -293,7 +293,11 @@ void __init prom_init(void)
* It's OK for direct boot to not provide a
* command line
*/
+#ifdef CONFIG_CMDLINE
+ strlcpy(arcs_cmdline, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
+#else
strcpy(arcs_cmdline, "root=/dev/ram0 ");
+#endif
} else {
/* The loader should have set the command line */
/* too early for panic to do any good */
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Honor CONFIG_CMDLINE on SiByte
2009-06-02 12:22 [PATCH] Honor CONFIG_CMDLINE on SiByte Imre Kaloz
@ 2009-06-02 17:59 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2009-06-02 17:59 UTC (permalink / raw)
To: Imre Kaloz; +Cc: linux-mips
On Tue, Jun 02, 2009 at 02:22:14PM +0200, Imre Kaloz wrote:
> The SiByte platform code doesn't honor the CONFIG_CMDLINE kernel
> option. This patch fixes this issue.
>
> Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
> ---
> arch/mips/sibyte/common/cfe.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/sibyte/common/cfe.c b/arch/mips/sibyte/common/cfe.c
> index 3de30f7..97e997e 100644
> --- a/arch/mips/sibyte/common/cfe.c
> +++ b/arch/mips/sibyte/common/cfe.c
> @@ -293,7 +293,11 @@ void __init prom_init(void)
> * It's OK for direct boot to not provide a
> * command line
> */
> +#ifdef CONFIG_CMDLINE
> + strlcpy(arcs_cmdline, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> +#else
> strcpy(arcs_cmdline, "root=/dev/ram0 ");
> +#endif
I rather think the strcpy should go instead. Hardwiring an option doesn't
seem a good idea.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-02 17:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-02 12:22 [PATCH] Honor CONFIG_CMDLINE on SiByte Imre Kaloz
2009-06-02 17:59 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.