From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: wm97xx - use EBUSY instead of EINVAL
Date: Wed, 3 Jun 2009 07:48:57 -0700 [thread overview]
Message-ID: <200906030748.58010.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20090603144024.GJ11507@sirena.org.uk>
On Wednesday 03 June 2009 07:40:24 Mark Brown wrote:
> On Wed, Jun 03, 2009 at 07:19:14AM -0700, Dmitry Torokhov wrote:
> > The "most correct" thing would be to propagate the value returned by
> > request_irq() I think but since nobidy actually uses result of
> > wm97xx_init_pen_irq() I just would not bother at all.
>
> Yeah, I was looking at that - the driver can run in polling mode so it's
> fine as-is. I could change the code to return void, I suppose.
Yes, I think that would be the best.
--
Dmitry
next prev parent reply other threads:[~2009-06-03 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 5:45 [PATCH] Input: wm97xx - use EBUSY instead of EINVAL Joonyoung Shim
2009-06-03 10:01 ` Mark Brown
2009-06-03 14:19 ` Dmitry Torokhov
2009-06-03 14:40 ` Mark Brown
2009-06-03 14:48 ` Dmitry Torokhov [this message]
2009-06-04 1:26 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906030748.58010.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.