From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] Input: wm97xx - use EBUSY instead of EINVAL
Date: Wed, 3 Jun 2009 11:01:21 +0100 [thread overview]
Message-ID: <20090603100120.GA31919@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4A260DEB.2040306@samsung.com>
On Wed, Jun 03, 2009 at 02:45:15PM +0900, Joonyoung Shim wrote:
> If request_irq() fails, we have to return -EBUSY instead of -EINVAL.
Could you provide a bit more explanation for this one, please? -EBUSY
seems to give entirely the wrong impression to applications since in the
systems where this driver will be deployed a failure to acquire the IRQ
is most likely to be due to incorrect platform data and it is highly
unlikely to resolve itself.
next prev parent reply other threads:[~2009-06-03 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 5:45 [PATCH] Input: wm97xx - use EBUSY instead of EINVAL Joonyoung Shim
2009-06-03 10:01 ` Mark Brown [this message]
2009-06-03 14:19 ` Dmitry Torokhov
2009-06-03 14:40 ` Mark Brown
2009-06-03 14:48 ` Dmitry Torokhov
2009-06-04 1:26 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603100120.GA31919@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.