All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andi Kleen <andi@firstfloor.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch][v2] swap: virtual swap readahead
Date: Thu, 4 Jun 2009 12:04:36 +0200	[thread overview]
Message-ID: <20090604100436.GA1602@cmpxchg.org> (raw)
In-Reply-To: <20090604104628.99520342.kamezawa.hiroyu@jp.fujitsu.com>

On Thu, Jun 04, 2009 at 10:46:28AM +0900, KAMEZAWA Hiroyuki wrote:

> I wonder (I just wonder..) can we add code like following here ?
> 
>    /* we do _readahead_ here. Then, we don't want to add too much jobs to vm/IO*/
>    if (swp != entry)
> 	gfp_mask &= ~__GFP_WAIT
> > +		page = read_swap_cache_async(swp, gfp_mask, vma, pos);
> 
> too slow ?

Good idea, certainly worth evaluating.  But not in this patch, I don't
want to change _everything_ at once :-)

	Thanks, Hannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andi Kleen <andi@firstfloor.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch][v2] swap: virtual swap readahead
Date: Thu, 4 Jun 2009 12:04:36 +0200	[thread overview]
Message-ID: <20090604100436.GA1602@cmpxchg.org> (raw)
In-Reply-To: <20090604104628.99520342.kamezawa.hiroyu@jp.fujitsu.com>

On Thu, Jun 04, 2009 at 10:46:28AM +0900, KAMEZAWA Hiroyuki wrote:

> I wonder (I just wonder..) can we add code like following here ?
> 
>    /* we do _readahead_ here. Then, we don't want to add too much jobs to vm/IO*/
>    if (swp != entry)
> 	gfp_mask &= ~__GFP_WAIT
> > +		page = read_swap_cache_async(swp, gfp_mask, vma, pos);
> 
> too slow ?

Good idea, certainly worth evaluating.  But not in this patch, I don't
want to change _everything_ at once :-)

	Thanks, Hannes

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-06-04 10:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 22:37 [patch][v2] swap: virtual swap readahead Johannes Weiner
2009-06-02 22:37 ` Johannes Weiner
2009-06-02 23:34 ` Andi Kleen
2009-06-02 23:34   ` Andi Kleen
2009-06-03 13:27   ` Johannes Weiner
2009-06-03 13:27     ` Johannes Weiner
2009-06-03 14:51     ` Rik van Riel
2009-06-03 14:51       ` Rik van Riel
2009-06-03 15:02       ` Andi Kleen
2009-06-03 15:02         ` Andi Kleen
2009-06-05 11:03     ` Minchan Kim
2009-06-05 11:03       ` Minchan Kim
2009-06-04  1:46 ` KAMEZAWA Hiroyuki
2009-06-04  1:46   ` KAMEZAWA Hiroyuki
2009-06-04 10:04   ` Johannes Weiner [this message]
2009-06-04 10:04     ` Johannes Weiner
2009-06-07 17:55 ` Hugh Dickins
2009-06-08 15:21   ` Johannes Weiner
2009-06-08 15:21     ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090604100436.GA1602@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.