From: Rusty Russell <rusty@rustcorp.com.au>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Divy Le Ray <divy@chelsio.com>, Roland Dreier <rolandd@cisco.com>,
Pavel Emelianov <xemul@openvz.org>,
Dan Williams <dcbw@redhat.com>,
libertas-dev@lists.infradead.org
Subject: Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit
Date: Thu, 4 Jun 2009 13:24:57 +0930 [thread overview]
Message-ID: <200906041324.59118.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4A26E4FD.5010405@gmail.com>
On Thu, 4 Jun 2009 06:32:53 am Eric Dumazet wrote:
> Rusty Russell a écrit :
> > On Sat, 30 May 2009 12:41:00 am Eric Dumazet wrote:
> >> For TCP, I agree your patch is a huge benefit, since its paced by remote
> >> ACKS and window control
> >
> > I doubt that. There'll be some cache friendliness, but I'm not sure
> > it'll be measurable, let alone "huge".
...
> We can see sock_wfree() being number 2 on the profile, because it touches
> three cache lines per socket and transmited packet in TX completion
> handler.
Interesting, I take it back: got some "after" stats as well?
> Also, taking a reference on socket for each xmit packet in flight is very
> expensive, since it slows down receiver in __udp4_lib_lookup(). Several
> cpus are fighting for sk->refcnt cache line.
Now we have decent dynamic per-cpu, we can finally implement bigrefs. More
obvious for device counts than sockets, but perhaps applicable here as well?
Rusty.
next prev parent reply other threads:[~2009-06-04 3:55 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 14:14 [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit Rusty Russell
2009-05-29 15:11 ` Eric Dumazet
2009-06-01 12:27 ` Rusty Russell
2009-06-03 21:02 ` Eric Dumazet
2009-06-03 21:02 ` Eric Dumazet
2009-06-04 3:54 ` Rusty Russell
2009-06-04 3:54 ` Rusty Russell [this message]
2009-06-04 4:00 ` David Miller
2009-06-04 4:54 ` Eric Dumazet
2009-06-04 4:56 ` David Miller
2009-06-04 4:56 ` David Miller
2009-06-04 9:18 ` [PATCH] net: No more expensive sock_hold()/sock_put() on each tx Eric Dumazet
2009-06-04 9:26 ` David Miller
2009-06-10 8:17 ` David Miller
2009-06-10 8:30 ` Eric Dumazet
2009-06-11 9:56 ` David Miller
2009-06-04 4:00 ` [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit David Miller
2009-05-29 15:11 ` Eric Dumazet
2009-06-01 19:47 ` Patrick Ohly
2009-06-02 7:25 ` David Miller
2009-06-02 14:08 ` Rusty Russell
2009-06-03 0:14 ` David Miller
2009-07-03 7:55 ` Herbert Xu
2009-07-03 7:55 ` Herbert Xu
2009-07-04 3:02 ` David Miller
2009-07-04 3:08 ` Herbert Xu
2009-07-04 3:13 ` David Miller
2009-07-04 7:42 ` Herbert Xu
2009-07-04 9:09 ` Herbert Xu
2009-07-04 9:09 ` Herbert Xu
2009-07-05 3:26 ` Herbert Xu
2009-07-05 3:34 ` Herbert Xu
2009-07-05 3:34 ` Herbert Xu
2009-08-18 1:47 ` David Miller
2009-08-19 3:19 ` Herbert Xu
2009-08-19 3:19 ` Herbert Xu
2009-08-19 3:34 ` David Miller
2009-08-19 3:34 ` David Miller
2009-08-18 1:47 ` David Miller
2009-07-04 7:42 ` Herbert Xu
2009-07-04 3:13 ` David Miller
2009-07-04 3:08 ` Herbert Xu
2009-06-02 14:08 ` Rusty Russell
2009-06-02 7:25 ` David Miller
2009-06-01 19:47 ` Patrick Ohly
-- strict thread matches above, loose matches on Subject: below --
2009-05-29 14:14 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906041324.59118.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=dcbw@redhat.com \
--cc=divy@chelsio.com \
--cc=eric.dumazet@gmail.com \
--cc=libertas-dev@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.