From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: Don't advertise i2c functions when not available
Date: Fri, 5 Jun 2009 09:42:26 +0100 [thread overview]
Message-ID: <20090605084226.GA17158@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20090605101330.2f93e9ab-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
On Fri, Jun 05, 2009 at 10:13:30AM +0200, Jean Delvare wrote:
> Surround i2c function declarations with ifdefs, so that they aren't
> advertised when i2c-core isn't actually built. That way, drivers using
> these functions unconditionally will result in an immediate build
> failure, rather than a late linking failure which is harder to figure
> out.
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-next@vger.kernel.org, linux-media@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: Don't advertise i2c functions when not available
Date: Fri, 5 Jun 2009 09:42:26 +0100 [thread overview]
Message-ID: <20090605084226.GA17158@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20090605101330.2f93e9ab@hyperion.delvare>
On Fri, Jun 05, 2009 at 10:13:30AM +0200, Jean Delvare wrote:
> Surround i2c function declarations with ifdefs, so that they aren't
> advertised when i2c-core isn't actually built. That way, drivers using
> these functions unconditionally will result in an immediate build
> failure, rather than a late linking failure which is harder to figure
> out.
Thanks!
next prev parent reply other threads:[~2009-06-05 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 7:08 [PATCH] i2c: Simplified CONFIG_I2C=n interface Paul Mundt
[not found] ` <20090527070850.GA11221-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2009-05-27 7:18 ` Jean Delvare
2009-05-27 7:18 ` Jean Delvare
[not found] ` <20090527091831.26b60d6d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-05-27 7:28 ` Paul Mundt
2009-05-27 7:28 ` Paul Mundt
2009-05-27 12:01 ` Mark Brown
2009-06-02 7:12 ` Jean Delvare
2009-06-02 9:34 ` Mark Brown
2009-06-05 8:13 ` [PATCH] i2c: Don't advertise i2c functions when not available Jean Delvare
[not found] ` <20090605101330.2f93e9ab-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-06-05 8:42 ` Mark Brown [this message]
2009-06-05 8:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605084226.GA17158@rakim.wolfsonmicro.main \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.