From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 3dcd219] Update irqs on reset and device load
Date: Wed, 10 Jun 2009 00:49:59 +0100 [thread overview]
Message-ID: <200906100050.00389.paul@codesourcery.com> (raw)
In-Reply-To: <200906091726.n59HQElX007760@d03av01.boulder.ibm.com>
On Tuesday 09 June 2009, Anthony Liguori wrote:
> From: Blue Swirl <blauwirbel@gmail.com>
>@@ -3314,6 +3314,8 @@ static int rtl8139_load(QEMUFile* f,void* opaque,int
> version_id) s->cplus_enabled = s->CpCmd != 0;
> }
>
>+ rtl8139_update_irq(s);
This should not be necessary.
PCI bus multiplexers should save/restore their own internal state.
In fact this patch only works by chance, and relies on the fact that the bus
multiplexers have no temporal state.
Paul
parent reply other threads:[~2009-06-09 23:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200906091726.n59HQElX007760@d03av01.boulder.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906100050.00389.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.