All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] Re: [Qemu-commits] [COMMIT 3dcd219] Update irqs on reset and device load
       [not found] <200906091726.n59HQElX007760@d03av01.boulder.ibm.com>
@ 2009-06-09 23:49 ` Paul Brook
  0 siblings, 0 replies; only message in thread
From: Paul Brook @ 2009-06-09 23:49 UTC (permalink / raw)
  To: qemu-devel, Blue Swirl

On Tuesday 09 June 2009, Anthony Liguori wrote:
> From: Blue Swirl <blauwirbel@gmail.com>
>@@ -3314,6 +3314,8 @@ static int rtl8139_load(QEMUFile* f,void* opaque,int
> version_id) s->cplus_enabled = s->CpCmd != 0;
>     }
>
>+    rtl8139_update_irq(s);

This should not be necessary.

PCI bus multiplexers should save/restore their own internal state.

In fact this patch only works by chance, and relies on the fact that the bus 
multiplexers have no temporal state.

Paul

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-09 23:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <200906091726.n59HQElX007760@d03av01.boulder.ibm.com>
2009-06-09 23:49 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 3dcd219] Update irqs on reset and device load Paul Brook

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.