From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Casey Schaufler <casey-iSGtlc1asvQWG2LlvL+J4A@public.gmane.org>
Cc: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
SELinux <selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>,
Linux Containers
<containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>,
Alexey Dobriyan
<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morgan <morgan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 10/10] cr: lsm: restore file->f_security
Date: Wed, 10 Jun 2009 08:58:33 -0500 [thread overview]
Message-ID: <20090610135833.GA14218@us.ibm.com> (raw)
In-Reply-To: <4A2F2B08.40701-iSGtlc1asvQWG2LlvL+J4A@public.gmane.org>
Quoting Casey Schaufler (casey-iSGtlc1asvQWG2LlvL+J4A@public.gmane.org):
> > @@ -1630,7 +1654,6 @@ static int smack_msg_msg_restore_security(struct msg_msg *msg,
> > msg->security = str;
> > }
> > return 0;
> > - return 0;
> >
>
> Looks like you caught that. Thank you
Huh. No, I didn't :) I'm guessing that both the original problem
and this accidental fix came about through my inexperience with
resolving conflicts in git-rebase...
Thanks for taking a look, I will address all of your comments in
the next posting.
For the next version I may split up the smack, selinux, and
tomoyo hooks into separate patches from the core LSM patch
(and nix the rather silly split of the security_file_restore
hook) for easier review...
thanks,
-serge
WARNING: multiple messages have this Message-ID (diff)
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Linux Containers <containers@lists.osdl.org>,
Oren Laadan <orenl@cs.columbia.edu>,
David Howells <dhowells@redhat.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morgan <morgan@kernel.org>,
SELinux <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 10/10] cr: lsm: restore file->f_security
Date: Wed, 10 Jun 2009 08:58:33 -0500 [thread overview]
Message-ID: <20090610135833.GA14218@us.ibm.com> (raw)
In-Reply-To: <4A2F2B08.40701@schaufler-ca.com>
Quoting Casey Schaufler (casey@schaufler-ca.com):
> > @@ -1630,7 +1654,6 @@ static int smack_msg_msg_restore_security(struct msg_msg *msg,
> > msg->security = str;
> > }
> > return 0;
> > - return 0;
> >
>
> Looks like you caught that. Thank you
Huh. No, I didn't :) I'm guessing that both the original problem
and this accidental fix came about through my inexperience with
resolving conflicts in git-rebase...
Thanks for taking a look, I will address all of your comments in
the next posting.
For the next version I may split up the smack, selinux, and
tomoyo hooks into separate patches from the core LSM patch
(and nix the rather silly split of the security_file_restore
hook) for easier review...
thanks,
-serge
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2009-06-10 13:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 1:44 [PATCH 01/10] cred: #include init.h in cred.h Serge E. Hallyn
[not found] ` <20090610014412.GA5628-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-10 1:44 ` [PATCH 02/10] groups: move code to kernel/groups.c Serge E. Hallyn
2009-06-10 1:44 ` [PATCH 03/10] cr: break out new_user_ns() Serge E. Hallyn
2009-06-10 1:44 ` [PATCH 04/10] cr: split core function out of some set*{u,g}id functions Serge E. Hallyn
[not found] ` <20090610014456.GC5658-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-10 12:20 ` James Morris
2009-06-10 12:51 ` Serge E. Hallyn
2009-06-10 1:45 ` [PATCH 05/10] cr: ipc: reset kern_ipc_perms Serge E. Hallyn
2009-06-10 1:45 ` [PATCH 06/10] cr: capabilities: define checkpoint and restore fns Serge E. Hallyn
2009-06-10 1:46 ` [PATCH 07/10] cr: checkpoint and restore task credentials Serge E. Hallyn
2009-06-10 1:46 ` [PATCH 08/10] cr: restore file->f_cred Serge E. Hallyn
2009-06-10 1:46 ` [PATCH 09/10] cr: restore LSM credentials Serge E. Hallyn
2009-06-10 1:46 ` Serge E. Hallyn
[not found] ` <20090610014637.GH5658-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-10 3:24 ` Casey Schaufler
2009-06-10 3:24 ` Casey Schaufler
2009-06-10 13:54 ` Stephen Smalley
2009-06-10 13:54 ` Stephen Smalley
[not found] ` <1244642042.20265.143.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-06-10 14:59 ` Serge E. Hallyn
2009-06-10 14:59 ` Serge E. Hallyn
2009-06-10 1:47 ` [PATCH 10/10] cr: lsm: restore file->f_security Serge E. Hallyn
2009-06-10 1:47 ` Serge E. Hallyn
[not found] ` <20090610014704.GI5658-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-10 3:39 ` Casey Schaufler
2009-06-10 3:39 ` Casey Schaufler
[not found] ` <4A2F2B08.40701-iSGtlc1asvQWG2LlvL+J4A@public.gmane.org>
2009-06-10 13:58 ` Serge E. Hallyn [this message]
2009-06-10 13:58 ` Serge E. Hallyn
2009-06-10 13:54 ` Stephen Smalley
2009-06-10 13:54 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610135833.GA14218@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=casey-iSGtlc1asvQWG2LlvL+J4A@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=morgan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.