All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] alsa: lx6464es - support index module parameter
@ 2009-06-10 21:41 Tim Blechmann
  2009-06-11  1:01 ` Takashi Iwai
  0 siblings, 1 reply; 5+ messages in thread
From: Tim Blechmann @ 2009-06-10 21:41 UTC (permalink / raw)
  To: alsa-devel; +Cc: Takashi Iwai


[-- Attachment #1.1: Type: text/plain, Size: 760 bytes --]

trivial patch to put the device to a specific index

Signed-off-by: Tim Blechmann <tim@klingt.org>
---
 sound/pci/lx6464es/lx6464es.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
index 870bfc5..dd0f12b 100644
--- a/sound/pci/lx6464es/lx6464es.c
+++ b/sound/pci/lx6464es/lx6464es.c
@@ -43,6 +43,9 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;
 static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;
 static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;
 
+module_param_array(index, int, NULL, 0444);
+MODULE_PARM_DESC(index, "Index value for Digigram LX6464ES interface.");
+
 static const char card_name[] = "LX6464ES";
 
 
-- 
1.6.2.1

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] alsa: lx6464es - support index module parameter
  2009-06-10 21:41 [PATCH] alsa: lx6464es - support index module parameter Tim Blechmann
@ 2009-06-11  1:01 ` Takashi Iwai
  2009-06-11  8:43   ` Tim Blechmann
  2009-06-11  9:09   ` [PATCH] alsa: lx6464es - support standard alsa module parameters Tim Blechmann
  0 siblings, 2 replies; 5+ messages in thread
From: Takashi Iwai @ 2009-06-11  1:01 UTC (permalink / raw)
  To: Tim Blechmann; +Cc: alsa-devel

At Wed, 10 Jun 2009 23:41:54 +0200,
Tim Blechmann wrote:
> 
> trivial patch to put the device to a specific index
> 
> Signed-off-by: Tim Blechmann <tim@klingt.org>
> ---
>  sound/pci/lx6464es/lx6464es.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
> index 870bfc5..dd0f12b 100644
> --- a/sound/pci/lx6464es/lx6464es.c
> +++ b/sound/pci/lx6464es/lx6464es.c
> @@ -43,6 +43,9 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;
>  static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;
>  static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;
>  
> +module_param_array(index, int, NULL, 0444);
> +MODULE_PARM_DESC(index, "Index value for Digigram LX6464ES interface.");

Please define the similar things for id and enable options.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] alsa: lx6464es - support index module parameter
  2009-06-11  1:01 ` Takashi Iwai
@ 2009-06-11  8:43   ` Tim Blechmann
  2009-06-11  9:09   ` [PATCH] alsa: lx6464es - support standard alsa module parameters Tim Blechmann
  1 sibling, 0 replies; 5+ messages in thread
From: Tim Blechmann @ 2009-06-11  8:43 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 1120 bytes --]

Takashi Iwai wrote:
> At Wed, 10 Jun 2009 23:41:54 +0200,
> Tim Blechmann wrote:
>> trivial patch to put the device to a specific index
>>
>> Signed-off-by: Tim Blechmann <tim@klingt.org>
>> ---
>>  sound/pci/lx6464es/lx6464es.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
>> index 870bfc5..dd0f12b 100644
>> --- a/sound/pci/lx6464es/lx6464es.c
>> +++ b/sound/pci/lx6464es/lx6464es.c
>> @@ -43,6 +43,9 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;
>>  static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;
>>  static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;
>>  
>> +module_param_array(index, int, NULL, 0444);
>> +MODULE_PARM_DESC(index, "Index value for Digigram LX6464ES interface.");
> 
> Please define the similar things for id and enable options.

oh, i wasn't aware of these parameters, just give me a second ...

-- 
tim@klingt.org
http://tim.klingt.org

Your mind will answer most questions if you learn to relax and wait
for the answer.
  William S. Burroughs


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] alsa: lx6464es - support standard alsa module parameters
  2009-06-11  1:01 ` Takashi Iwai
  2009-06-11  8:43   ` Tim Blechmann
@ 2009-06-11  9:09   ` Tim Blechmann
  2009-06-11 14:35     ` Takashi Iwai
  1 sibling, 1 reply; 5+ messages in thread
From: Tim Blechmann @ 2009-06-11  9:09 UTC (permalink / raw)
  To: alsa-devel


[-- Attachment #1.1: Type: text/plain, Size: 1044 bytes --]

trivial patch to support the alsa module parameters `index', `id'
and `enable'

Signed-off-by: Tim Blechmann <tim@klingt.org>
---
 sound/pci/lx6464es/lx6464es.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
index 870bfc5..ccf1b38 100644
--- a/sound/pci/lx6464es/lx6464es.c
+++ b/sound/pci/lx6464es/lx6464es.c
@@ -43,6 +43,13 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;
 static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;
 static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;
 
+module_param_array(index, int, NULL, 0444);
+MODULE_PARM_DESC(index, "Index value for Digigram LX6464ES interface.");
+module_param_array(id, charp, NULL, 0444);
+MODULE_PARM_DESC(id, "ID string for  Digigram LX6464ES interface.");
+module_param_array(enable, bool, NULL, 0444);
+MODULE_PARM_DESC(enable, "Enable/disable specific Digigram LX6464ES soundcards.");
+
 static const char card_name[] = "LX6464ES";
 
 
-- 
1.6.2.1


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] alsa: lx6464es - support standard alsa module parameters
  2009-06-11  9:09   ` [PATCH] alsa: lx6464es - support standard alsa module parameters Tim Blechmann
@ 2009-06-11 14:35     ` Takashi Iwai
  0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2009-06-11 14:35 UTC (permalink / raw)
  To: Tim Blechmann; +Cc: alsa-devel

At Thu, 11 Jun 2009 11:09:00 +0200,
Tim Blechmann wrote:
> 
> [1  <multipart/signed (7bit)>]
> [1.1  <text/plain; US-ASCII (quoted-printable)>]
> trivial patch to support the alsa module parameters `index', `id'
> and `enable'
> 
> Signed-off-by: Tim Blechmann <tim@klingt.org>

Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-06-11 14:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 21:41 [PATCH] alsa: lx6464es - support index module parameter Tim Blechmann
2009-06-11  1:01 ` Takashi Iwai
2009-06-11  8:43   ` Tim Blechmann
2009-06-11  9:09   ` [PATCH] alsa: lx6464es - support standard alsa module parameters Tim Blechmann
2009-06-11 14:35     ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.