All of lore.kernel.org
 help / color / mirror / Atom feed
From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Linuxppc-dev <Linuxppc-dev@ozlabs.org>
Cc: Sachin P Sant <sachinp@linux.vnet.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-Next <linux-next@vger.kernel.org>,
	Subrata Modak <subrata@linux.vnet.ibm.com>,
	Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o]
Date: Thu, 11 Jun 2009 09:20:46 +0530	[thread overview]
Message-ID: <20090611035046.22125.26641.sendpatchset@subratamodak.linux.ibm.com> (raw)

Hi Benjamin/Paul,

>On Thu, 2009-06-04 at 19:02 +0530, Subrata Modak wrote:
>CC      drivers/net/lance.o
> drivers/net/lance.c: In function 'lance_probe1':
> drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'
> drivers/net/lance.c: In function 'lance_rx':
> drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt'
> make[2]: *** [drivers/net/lance.o] Error 1
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2

Reference: http://lkml.org/lkml/2009/6/4/240,
To fix the following build error:

drivers/net/lance.c: In function 'lance_probe1':
drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'
drivers/net/lance.c: In function 'lance_rx':
drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt'
make[2]: *** [drivers/net/lance.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

I would like to propose the following patch. The prototypes for the functions:
'isa_virt_to_bus' & 'isa_virt_to_bus' are existing for some archs like the
mips, x86, parisc, arm & alpha, but, is missing for powerpc. Is it safe to
introduce the following soultion for powerpc ? It fixes the build problem
i reported earlier.

Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
---

--- linux-2.6.30-rc8/arch/powerpc/include/asm/io.h.orig	2009-06-10 21:56:49.000000000 -0500
+++ linux-2.6.30-rc8/arch/powerpc/include/asm/io.h	2009-06-10 22:21:35.000000000 -0500
@@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig
 #define mmio_outsw(addr, src, count)	writesw(addr, src, count)
 #define mmio_outsl(addr, src, count)	writesl(addr, src, count)
 
+#define isa_virt_to_bus		virt_to_phys
+#define isa_bus_to_virt		phys_to_virt
+
 /**
  *	virt_to_phys	-	map virtual addresses to physical
  *	@address: address to remap

---
Regards--
Subrata

WARNING: multiple messages have this Message-ID (diff)
From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Linuxppc-dev <Linuxppc-dev@ozlabs.org>
Cc: Sachin P Sant <sachinp@linux.vnet.ibm.com>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-Next <linux-next@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Subrata Modak <subrata@linux.vnet.ibm.com>,
	Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o]
Date: Thu, 11 Jun 2009 09:20:46 +0530	[thread overview]
Message-ID: <20090611035046.22125.26641.sendpatchset@subratamodak.linux.ibm.com> (raw)

Hi Benjamin/Paul,

>On Thu, 2009-06-04 at 19:02 +0530, Subrata Modak wrote:
>CC      drivers/net/lance.o
> drivers/net/lance.c: In function 'lance_probe1':
> drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'
> drivers/net/lance.c: In function 'lance_rx':
> drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt'
> make[2]: *** [drivers/net/lance.o] Error 1
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2

Reference: http://lkml.org/lkml/2009/6/4/240,
To fix the following build error:

drivers/net/lance.c: In function 'lance_probe1':
drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'
drivers/net/lance.c: In function 'lance_rx':
drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt'
make[2]: *** [drivers/net/lance.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

I would like to propose the following patch. The prototypes for the functions:
'isa_virt_to_bus' & 'isa_virt_to_bus' are existing for some archs like the
mips, x86, parisc, arm & alpha, but, is missing for powerpc. Is it safe to
introduce the following soultion for powerpc ? It fixes the build problem
i reported earlier.

Signed-off-by: Subrata Modak <subrata@linux.vnet.ibm.com>
---

--- linux-2.6.30-rc8/arch/powerpc/include/asm/io.h.orig	2009-06-10 21:56:49.000000000 -0500
+++ linux-2.6.30-rc8/arch/powerpc/include/asm/io.h	2009-06-10 22:21:35.000000000 -0500
@@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig
 #define mmio_outsw(addr, src, count)	writesw(addr, src, count)
 #define mmio_outsl(addr, src, count)	writesl(addr, src, count)
 
+#define isa_virt_to_bus		virt_to_phys
+#define isa_bus_to_virt		phys_to_virt
+
 /**
  *	virt_to_phys	-	map virtual addresses to physical
  *	@address: address to remap

---
Regards--
Subrata


             reply	other threads:[~2009-06-11  3:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11  3:50 Subrata Modak [this message]
2009-06-11  3:50 ` [PATCH][BUILD FAILURE 03/04] Next June 04:PPC64 randconfig [drivers/net/lance.o] Subrata Modak
2009-06-15  6:51 ` Subrata Modak
2009-06-15  6:51   ` Subrata Modak
2009-06-15  7:11   ` Benjamin Herrenschmidt
2009-06-15  7:11     ` Benjamin Herrenschmidt
2009-06-15  7:21     ` Subrata Modak
2009-06-15  7:21       ` Subrata Modak
2009-06-15  9:43       ` Benjamin Herrenschmidt
2009-06-15  9:43         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090611035046.22125.26641.sendpatchset@subratamodak.linux.ibm.com \
    --to=subrata@linux.vnet.ibm.com \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=sachinp@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.