All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@canonical.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>,
	riel@redhat.com, minchan.kim@gmail.com
Subject: Re: [PATCH 1/2] lumpy reclaim: clean up and write lumpy reclaim
Date: Thu, 11 Jun 2009 09:01:37 +0100	[thread overview]
Message-ID: <20090611080137.GD28011@shadowen.org> (raw)
In-Reply-To: <20090610095140.GB25943@csn.ul.ie>

On Wed, Jun 10, 2009 at 10:51:40AM +0100, Mel Gorman wrote:
> On Wed, Jun 10, 2009 at 02:24:43PM +0900, KAMEZAWA Hiroyuki wrote:
> > I think lumpy reclaim should be updated to meet to current split-lru.
> > This patch includes bugfix and cleanup. How do you think ?
> > 
> 
> I think it needs to be split up into its component parts. This patch is
> changing too much and it's very difficult to consider each change in
> isolation.

I can only echo Mels comments here.  It is very hard to review such a
large patch which mostly is fixing a very small change.  This code is
pretty fragile and would need significant testing, I don't know if Mel
is able to run the same tests we used when putting this together in the
first place.

By the looks of the rest of the thread Kame-san is going to break this
up so I'll wait for that.

Thanks!

-apw

WARNING: multiple messages have this Message-ID (diff)
From: Andy Whitcroft <apw@canonical.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>,
	riel@redhat.com, minchan.kim@gmail.com
Subject: Re: [PATCH 1/2] lumpy reclaim: clean up and write lumpy reclaim
Date: Thu, 11 Jun 2009 09:01:37 +0100	[thread overview]
Message-ID: <20090611080137.GD28011@shadowen.org> (raw)
In-Reply-To: <20090610095140.GB25943@csn.ul.ie>

On Wed, Jun 10, 2009 at 10:51:40AM +0100, Mel Gorman wrote:
> On Wed, Jun 10, 2009 at 02:24:43PM +0900, KAMEZAWA Hiroyuki wrote:
> > I think lumpy reclaim should be updated to meet to current split-lru.
> > This patch includes bugfix and cleanup. How do you think ?
> > 
> 
> I think it needs to be split up into its component parts. This patch is
> changing too much and it's very difficult to consider each change in
> isolation.

I can only echo Mels comments here.  It is very hard to review such a
large patch which mostly is fixing a very small change.  This code is
pretty fragile and would need significant testing, I don't know if Mel
is able to run the same tests we used when putting this together in the
first place.

By the looks of the rest of the thread Kame-san is going to break this
up so I'll wait for that.

Thanks!

-apw

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-06-11  8:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10  5:24 [PATCH 1/2] lumpy reclaim: clean up and write lumpy reclaim KAMEZAWA Hiroyuki
2009-06-10  5:24 ` KAMEZAWA Hiroyuki
2009-06-10  5:27 ` [PATCH 2/2] memcg: fix LRU rotation at __isolate_page KAMEZAWA Hiroyuki
2009-06-10  5:27   ` KAMEZAWA Hiroyuki
2009-06-10  6:11 ` [PATCH 1/2] lumpy reclaim: clean up and write lumpy reclaim KOSAKI Motohiro
2009-06-10  6:11   ` KOSAKI Motohiro
2009-06-10  6:30   ` KAMEZAWA Hiroyuki
2009-06-10  6:30     ` KAMEZAWA Hiroyuki
2009-06-10  6:32     ` KOSAKI Motohiro
2009-06-10  6:32       ` KOSAKI Motohiro
2009-06-10  9:51 ` Mel Gorman
2009-06-10  9:51   ` Mel Gorman
2009-06-10 11:36   ` KAMEZAWA Hiroyuki
2009-06-10 11:36     ` KAMEZAWA Hiroyuki
2009-06-10 13:35     ` Mel Gorman
2009-06-10 13:35       ` Mel Gorman
2009-06-11  0:04       ` KAMEZAWA Hiroyuki
2009-06-11  0:04         ` KAMEZAWA Hiroyuki
2009-06-11  8:01   ` Andy Whitcroft [this message]
2009-06-11  8:01     ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090611080137.GD28011@shadowen.org \
    --to=apw@canonical.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.