All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Tomaz Mertelj <tomaz.mertelj@guest.arnes.si>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	Harald Welte <HaraldWelte@viatech.com>
Subject: Re: [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core
Date: Thu, 11 Jun 2009 22:32:55 +0000	[thread overview]
Message-ID: <20090611153255.ba8d6c54.akpm@linux-foundation.org> (raw)
In-Reply-To: <loom.20090610T172830-164@post.gmane.org>

On Wed, 10 Jun 2009 17:40:31 +0000 (UTC)
Tomaz Mertelj <tomaz.mertelj@guest.arnes.si> wrote:

> Harald Welte <HaraldWelte <at> viatech.com> writes:
> 
> > 
> > This is a driver for the on-die digital temperature sensor of
> > VIA's recent CPU models.
> > 
> > Signed-off-by: Harald Welte <HaraldWelte <at> viatech.com>
> > 
> 
> Harald,

You carefully removed Harald from Cc: so he probably didn't read your
email.

> I tested it on 2.6.28.3 kernel on VIA VB7002 motherboard and it does not work 
> correctly.
> 
> Output form sensors:
> 
> via-cputemp-isa-0000
> Adapter: ISA adapter
> Core 0:       +0.0 C
> 
> On the other hand 
> cat '/sys/class/hwmon/hwmon2/device/driver/via-cputemp.0/temp1_input' outputs 
> numbers between 25-27. 
> 

Thanks for testing it.

Harald, please cc myself on updates to this patch.

<looks quickly at the patch>

It has a few trivial coding-style glitches.  Please use checkpatch.

Please take a look at using hotcpu_notifier() rather than a bare
register_hotcpu_notifier().  Many ifdefs should fall away as a result.


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Tomaz Mertelj <tomaz.mertelj@guest.arnes.si>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	Harald Welte <HaraldWelte@viatech.com>
Subject: Re: [PATCH] hwmon: Add driver for VIA CPU core temperature
Date: Thu, 11 Jun 2009 15:32:55 -0700	[thread overview]
Message-ID: <20090611153255.ba8d6c54.akpm@linux-foundation.org> (raw)
In-Reply-To: <loom.20090610T172830-164@post.gmane.org>

On Wed, 10 Jun 2009 17:40:31 +0000 (UTC)
Tomaz Mertelj <tomaz.mertelj@guest.arnes.si> wrote:

> Harald Welte <HaraldWelte <at> viatech.com> writes:
> 
> > 
> > This is a driver for the on-die digital temperature sensor of
> > VIA's recent CPU models.
> > 
> > Signed-off-by: Harald Welte <HaraldWelte <at> viatech.com>
> > 
> 
> Harald,

You carefully removed Harald from Cc: so he probably didn't read your
email.

> I tested it on 2.6.28.3 kernel on VIA VB7002 motherboard and it does not work 
> correctly.
> 
> Output form sensors:
> 
> via-cputemp-isa-0000
> Adapter: ISA adapter
> Core 0:       +0.0 C
> 
> On the other hand 
> cat '/sys/class/hwmon/hwmon2/device/driver/via-cputemp.0/temp1_input' outputs 
> numbers between 25-27. 
> 

Thanks for testing it.

Harald, please cc myself on updates to this patch.

<looks quickly at the patch>

It has a few trivial coding-style glitches.  Please use checkpatch.

Please take a look at using hotcpu_notifier() rather than a bare
register_hotcpu_notifier().  Many ifdefs should fall away as a result.


  parent reply	other threads:[~2009-06-11 22:32 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09  8:34 [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Harald Welte
2009-06-09  8:34 ` Harald Welte
2009-06-10 17:40 ` Tomaz Mertelj
2009-06-11 22:02   ` Tomaz Mertelj
2009-06-11 22:32   ` Andrew Morton [this message]
2009-06-11 22:32     ` Andrew Morton
2009-06-12  8:12     ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Jean Delvare
2009-06-12  8:12       ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Jean Delvare
2009-06-12  9:11       ` Tomaz Mertelj
2009-06-12  9:27       ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU Harald Welte
2009-06-12  9:27         ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Harald Welte
2009-06-12 11:46       ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Michael S. Zick
2009-06-12 11:46         ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Michael S. Zick
2009-06-12 12:54         ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU Harald Welte
2009-06-12 12:54           ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Harald Welte
2009-06-12 13:09           ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Michael S. Zick
2009-06-12 13:09             ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Michael S. Zick
2009-06-12 13:41           ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Michael S. Zick
2009-06-12 13:41             ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Michael S. Zick
2009-06-12 13:47             ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Michael S. Zick
2009-06-12 13:47               ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Michael S. Zick
2009-06-12 14:23             ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Michael S. Zick
2009-06-12 14:23               ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Michael S. Zick
2009-06-19 21:11 ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Jean Delvare
2009-06-19 21:11   ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Jean Delvare
2009-06-27 18:34   ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Juerg Haefliger
2009-06-27 18:34     ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Juerg Haefliger
2009-08-13 18:42     ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Juerg Haefliger
2009-08-13 18:42       ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Juerg Haefliger
2009-08-19 14:32       ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Harald Welte
2009-08-19 14:32         ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Harald Welte
2009-08-19 16:52         ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Juerg Haefliger
2009-08-19 16:52           ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Juerg Haefliger
2009-12-09  7:17           ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Harald Welte
2009-12-09  7:17             ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core temperature Harald Welte
2009-12-10 19:39 ` Jean Delvare
2009-12-11 17:43 ` [lm-sensors] [PATCH] hwmon: Add driver for VIA CPU core Juerg Haefliger
2009-12-12  7:55 ` Harald Welte
2009-12-12 10:48 ` Adam Nielsen
2009-12-12 13:57 ` Jean Delvare
2009-12-15 20:27 ` Andre Prendel
2009-12-16  9:27 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090611153255.ba8d6c54.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=HaraldWelte@viatech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=tomaz.mertelj@guest.arnes.si \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.