From: Stephen Hemminger <shemminger@vyatta.com>
To: Jay Vosburg <fubar@us.ibm.com>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bonding-devel@lists.sourceforge.net
Subject: [PATCH 8/9] bonding: use is_zero_ether_addr
Date: Fri, 12 Jun 2009 22:02:51 -0700 [thread overview]
Message-ID: <20090613050422.202722960@vyatta.com> (raw)
In-Reply-To: 20090613050243.100086546@vyatta.com
[-- Attachment #1: bond-zeroaddr.patch --]
[-- Type: text/plain, Size: 928 bytes --]
Remove bogus non-portable possibly unaligned way of testing
for zero addres..
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/bonding/bond_sysfs.c 2009-06-12 21:46:35.171609407 -0700
+++ b/drivers/net/bonding/bond_sysfs.c 2009-06-12 21:46:36.103625198 -0700
@@ -33,6 +33,7 @@
#include <linux/ctype.h>
#include <linux/inet.h>
#include <linux/rtnetlink.h>
+#include <linux/etherdevice.h>
#include <net/net_namespace.h>
#include "bonding.h"
@@ -275,10 +276,9 @@ static ssize_t bonding_store_slaves(stru
/* If this is the first slave, then we need to set
the master's hardware address to be the same as the
slave's. */
- if (!(*((u32 *) & (bond->dev->dev_addr[0])))) {
+ if (is_zero_ether_addr(bond->dev->dev_addr))
memcpy(bond->dev->dev_addr, dev->dev_addr,
dev->addr_len);
- }
/* Set the slave's MTU to match the bond */
original_mtu = dev->mtu;
--
next prev parent reply other threads:[~2009-06-13 5:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 5:02 [PATCH 0/9] Bonding patches for 2.6.31 Stephen Hemminger
2009-06-13 5:02 ` [PATCH 1/9] bonding: bond_create always called with default parameters Stephen Hemminger
2009-06-13 5:02 ` [PATCH 2/9] bonding: initialize before registration Stephen Hemminger
2009-06-13 5:02 ` [PATCH 3/9] Subjec: bonding: remove bonding read/write semaphore Stephen Hemminger
2009-06-13 5:02 ` [PATCH 4/9] bonding: fix destructor Stephen Hemminger
2009-06-13 5:02 ` [PATCH 5/9] bonding: fix style issues Stephen Hemminger
2009-06-13 5:02 ` [PATCH 6/9] bonding: elminate bad refcount code Stephen Hemminger
2009-06-13 5:02 ` [PATCH 7/9] bonding: network device names are case sensative Stephen Hemminger
2009-06-13 5:02 ` Stephen Hemminger [this message]
2009-06-13 5:02 ` [PATCH 9/9] bonding: initialization rework Stephen Hemminger
2009-06-14 6:37 ` [PATCH 0/9] Bonding patches for 2.6.31 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613050422.202722960@vyatta.com \
--to=shemminger@vyatta.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.