All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave McCracken <dcm@mccr.org>
To: Xen Developers List <xen-devel@lists.xensource.com>
Subject: Baffled by multipage_allocation_permitted()
Date: Mon, 15 Jun 2009 16:44:50 -0500	[thread overview]
Message-ID: <200906151644.51978.dcm@mccr.org> (raw)


I have completed changes that allow me to create/save/restore domains 
allocated with 2M pages and run kernels with hugepage support.  This all 
appears to work fine.

However, while teaching the balloon driver to work in 2M page sizes, I 
suddenly had the multipage_allocation_permitted() macro in the hypervisor 
start failing.  This macro has the definition:

#define multipage_allocation_permitted(d)   \
   (!rangeset_is_empty((d)->iomem_caps) || \
    !rangeset_is_empty((d)->arch.ioport_caps))

I had never tracked down the significance of this macro since it didn't appear 
to be an issue.  Now it's suddenly denying me the ability to work in 2M pages.

What is this macro trying to achieve?  Why is it necessary?  Is there any 
compelling reason we can't just remove it and allow multipage allocations from 
any domain?

Thanks,
Dave McCracken
Oracle Corp.

             reply	other threads:[~2009-06-15 21:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 21:44 Dave McCracken [this message]
2009-06-15 21:57 ` Baffled by multipage_allocation_permitted() Keir Fraser
2009-06-16  9:19   ` Jan Beulich
2009-06-16  9:41     ` Keir Fraser
2009-06-16 13:10       ` Dave McCracken
2009-06-16 13:21         ` Keir Fraser
2009-06-16 13:23         ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906151644.51978.dcm@mccr.org \
    --to=dcm@mccr.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.