From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Dave McCracken <dcm@mccr.org>,
Xen Developers List <xen-devel@lists.xensource.com>
Subject: Re: Baffled by multipage_allocation_permitted()
Date: Mon, 15 Jun 2009 22:57:03 +0100 [thread overview]
Message-ID: <C65C823F.D4FF%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <200906151644.51978.dcm@mccr.org>
On 15/06/2009 22:44, "Dave McCracken" <dcm@mccr.org> wrote:
> #define multipage_allocation_permitted(d) \
> (!rangeset_is_empty((d)->iomem_caps) || \
> !rangeset_is_empty((d)->arch.ioport_caps))
>
> I had never tracked down the significance of this macro since it didn't appear
> to be an issue. Now it's suddenly denying me the ability to work in 2M pages.
>
> What is this macro trying to achieve? Why is it necessary? Is there any
> compelling reason we can't just remove it and allow multipage allocations from
> any domain?
We can just get rid of it I think. There are arguably worse other things we
already allow, like any guest can allocate low memory by specifying a small
value of XENMEMF_address_bits().
-- Keir
next prev parent reply other threads:[~2009-06-15 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 21:44 Baffled by multipage_allocation_permitted() Dave McCracken
2009-06-15 21:57 ` Keir Fraser [this message]
2009-06-16 9:19 ` Jan Beulich
2009-06-16 9:41 ` Keir Fraser
2009-06-16 13:10 ` Dave McCracken
2009-06-16 13:21 ` Keir Fraser
2009-06-16 13:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C65C823F.D4FF%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=dcm@mccr.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.