From: Christoph Egger <Christoph.Egger@amd.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] xen: fix s3 resume on AMD CPUs
Date: Tue, 16 Jun 2009 10:52:52 +0200 [thread overview]
Message-ID: <200906161052.53352.Christoph.Egger@amd.com> (raw)
In-Reply-To: <4A3774610200007800005DF7@vpn.id2.novell.com>
On Tuesday 16 June 2009 10:30:57 Jan Beulich wrote:
> >>> Christoph Egger <Christoph.Egger@amd.com> 15.06.09 17:33 >>>
> >
> >@@ -174,8 +177,11 @@ wakeup_64:
> > mov $(__HYPERVISOR_DS64), %eax
> > mov %eax, %ds
> >
> >- # long jump to return point, with cs reload
> >- rex64 ljmp *ret_point(%rip)
> >+ /* Continue with wakeup in the high-level wakeup code.
> >+ * Reload cs there.
> >+ */
> >+ movq ret_point(%rip), %rbx
> >+ jmp *%rbx
> >
> > .align 8
> > ret_point:
>
> Why do you add a comment ("Reload cs here") here that is not in sync with
> the changed code?
Re-read: You missed the "t"
:)
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2009-06-16 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 8:00 [PATCH] xen: fix s3 resume on AMD CPUs Christoph Egger
2009-06-05 8:21 ` Keir Fraser
2009-06-15 15:33 ` Christoph Egger
2009-06-16 8:30 ` Jan Beulich
2009-06-16 8:52 ` Christoph Egger [this message]
2009-06-16 9:38 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906161052.53352.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=JBeulich@novell.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.