All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Christoph Egger <Christoph.Egger@amd.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xen: fix s3 resume on AMD CPUs
Date: Fri, 05 Jun 2009 09:21:26 +0100	[thread overview]
Message-ID: <C64E9416.CDC3%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <200906051000.52397.Christoph.Egger@amd.com>

On 05/06/2009 09:00, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> attached patch fixes S3 resume on AMD CPUs.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Please make a minimal patch and explain each individual change. This one has
bizarre additional alignment, nops, double short jumps, longjmp->shortjmp
but keeps a comment which is then incorrect. Why are they needed? Is the
need documented? I don't see anything similar in Linux 2.6.27 wakeup
routines (2.6.27 is what I happen to have to hand).

I won't take your random permutations on this file of all files especially,
since it is a pain in the arse to debug when it gets broken.

 -- Keir

  reply	other threads:[~2009-06-05  8:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05  8:00 [PATCH] xen: fix s3 resume on AMD CPUs Christoph Egger
2009-06-05  8:21 ` Keir Fraser [this message]
2009-06-15 15:33   ` Christoph Egger
2009-06-16  8:30     ` Jan Beulich
2009-06-16  8:52       ` Christoph Egger
2009-06-16  9:38       ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C64E9416.CDC3%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=Christoph.Egger@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.