All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: updates on ckpt-v16-dev
Date: Tue, 16 Jun 2009 14:31:28 -0500	[thread overview]
Message-ID: <20090616193128.GA3854@us.ibm.com> (raw)
In-Reply-To: <4A37E901.1040403-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>

Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org):
> 
> I pushed a bunch of updates on ckpt-v16-dev, including many fixes
> and support for zombies.
> 
> I did little testing, but preferred to shoot it out as I'll be out
> for the next 24 hours at least.
> 
> updates are to both user and kernel.
> 
> Serge: please review the patch that fixes the user namespace.

You removed the #include of <linux/init.h> from kernel/groups.c.
I hear that works ok for x86, but on s390 it breaks my compiles.

Also, in kernel/user_namespace.c:do_restore_userns() you have
a #ifdef CONFIG_USER_NS, but user_namespace.o only gets compiled
if CONFIG_USER_NS.

Otherwise the user_ns patch does look good.  I'm happy to do without
the hackier-feeling flag.

thanks,
-serge

      parent reply	other threads:[~2009-06-16 19:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 18:48 updates on ckpt-v16-dev Oren Laadan
     [not found] ` <4A37E901.1040403-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-06-16 19:31   ` Serge E. Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090616193128.GA3854@us.ibm.com \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.