From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Cc: Keir Fraser <Keir.Fraser@eu.citrix.com>
Subject: [PATCH][SVM] fix spinlock panic
Date: Wed, 17 Jun 2009 16:20:48 +0200 [thread overview]
Message-ID: <200906171620.49105.Christoph.Egger@amd.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
Hi!
Attached patch enables irq when initializing SVM so it's safe to take locks.
This fixes a panic like this:
(XEN) Xen BUG at spinlock.c:24
[...]
(XEN) Xen call trace:
(XEN) [<ffff828c8011b839>] check_lock+0x3d/0x49
(XEN) [<ffff828c8011b9a4>] _spin_lock+0x11/0x2d
(XEN) [<ffff828c80111d4e>] alloc_heap_pages+0xcf/0x43d
(XEN) [<ffff828c80113775>] alloc_domheap_pages+0x115/0x160
(XEN) [<ffff828c80113810>] alloc_xenheap_pages+0x50/0xd7
(XEN) [<ffff828c801a4163>] alloc_host_save_area+0x18/0x45
(XEN) [<ffff828c801a21b0>] start_svm+0x6b/0x1f5
(XEN) [<ffff828c80184b5d>] init_amd+0x92b/0x96e
(XEN) [<ffff828c801852cf828c80163108>] smp_store_cpu_info+0x3b/0xbd
(XEN) [<ffff828c8016328b>] smp_callin+0x101/0x217
(XEN) [<ffff828c80164314>] start_secondary+0xb0/0x419
Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
[-- Attachment #2: xen_svm_irq.diff --]
[-- Type: text/x-diff, Size: 499 bytes --]
diff -r 45ca3f3c3f98 xen/arch/x86/hvm/svm/svm.c
--- a/xen/arch/x86/hvm/svm/svm.c Tue Jun 16 11:53:47 2009 +0100
+++ b/xen/arch/x86/hvm/svm/svm.c Wed Jun 17 16:15:44 2009 +0200
@@ -850,6 +850,9 @@ int start_svm(struct cpuinfo_x86 *c)
ecx = cpuid_ecx(0x80000001);
boot_cpu_data.x86_capability[5] = ecx;
+ /* Now enable interrupts so it's safe to take locks. */
+ local_irq_enable();
+
if ( !(test_bit(X86_FEATURE_SVME, &boot_cpu_data.x86_capability)) )
return 0;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2009-06-17 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 14:20 Christoph Egger [this message]
2009-06-18 8:51 ` [PATCH][SVM] fix spinlock panic Keir Fraser
2009-06-18 9:25 ` Christoph Egger
2009-06-18 9:47 ` Keir Fraser
2009-06-18 11:27 ` Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906171620.49105.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.