From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH][SVM] fix spinlock panic
Date: Thu, 18 Jun 2009 10:47:07 +0100 [thread overview]
Message-ID: <C65FCBAB.DA80%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <200906181125.36369.Christoph.Egger@amd.com>
On 18/06/2009 10:25, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
>> dangerous to reset the ASID generation back to zero); Also, as well as not
>> reallocating hsa and root_vmcb, we don't re-init them either. I don't know
>> ehether that strictly matters but obviously we could easily re-jig the code
>> to always clear_page() those pages unconditionally.
>
> Thanks for it. Regarding ASID, I will ask back.
> Now, I trigger an ASSERT() called by setup_vmcb_dump():
>
> (XEN) Assertion 'key_table[key].u.handler == ((void*)0)' failed at
> keyhandler.c:68
Oh good grief, I got the test at the top of start_svm() inverted. Please try
changeset 19798 which fixes this.
-- Keir
next prev parent reply other threads:[~2009-06-18 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 14:20 [PATCH][SVM] fix spinlock panic Christoph Egger
2009-06-18 8:51 ` Keir Fraser
2009-06-18 9:25 ` Christoph Egger
2009-06-18 9:47 ` Keir Fraser [this message]
2009-06-18 11:27 ` Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C65FCBAB.DA80%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.