All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Michael Riepe <michael.riepe@googlemail.com>
Cc: linux-kernel@vger.kernel.org, Rudolf Marek <r.marek@assembler.cz>,
	lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH] Enable coretemp driver on Intel Atom
Date: Thu, 18 Jun 2009 19:13:26 +0000	[thread overview]
Message-ID: <20090618121326.42ab9c2f.akpm@linux-foundation.org> (raw)
In-Reply-To: <49E7C34A.60007@googlemail.com>

On Fri, 17 Apr 2009 01:46:18 +0200
Michael Riepe <michael.riepe@googlemail.com> wrote:

> This small patch enables the coretemp driver on an Intel Atom. I'm not
> sure if the readings are correct, however - on my 330, the driver
> reports values between 27 and 41 __C (with core1 being about 8__C hotter
> than core0, given the same load). Maybe the maximum temperature of 100
> __C is wrong for Atom CPUs.
> 
> -- 
> Michael "Tired" Riepe <michael.riepe@googlemail.com>
> X-Tired: Each morning I get up I die a little
> 
> 
> [linux-2.6.29.1-coretemp-atom.diff  text/plain (916B)]
> Signed-off-by: Michael Riepe <michael.riepe@googlemail.com>
> 
> Index: drivers/hwmon/coretemp.c
> =================================> RCS file: /var/cvs/sys/kernel/linux-2.6/drivers/hwmon/coretemp.c,v
> retrieving revision 1.1.1.5
> diff -u -r1.1.1.5 coretemp.c
> --- drivers/hwmon/coretemp.c	11 Jan 2009 21:29:23 -0000	1.1.1.5
> +++ drivers/hwmon/coretemp.c	16 Apr 2009 23:02:40 -0000
> @@ -185,7 +185,7 @@
>  		}
>  	}
>  
> -	if (ismobile) {
> +	if (ismobile || c->x86_model = 0x1c) {
>  
>  		err = rdmsr_safe_on_cpu(id, 0xee, &eax, &edx);
>  		if (err) {
> @@ -417,7 +417,7 @@
>  		if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
>  		    !((c->x86_model = 0xe) || (c->x86_model = 0xf) ||
>  			(c->x86_model = 0x16) || (c->x86_model = 0x17) ||
> -			(c->x86_model = 0x1A))) {
> +			(c->x86_model = 0x1A) || (c->x86_model = 0x1c))) {
>  
>  			/* supported CPU not found, but report the unknown
>  			   family 6 CPU */
> 

I'm not 100% sure what to do about this patch.  I'm inclined to merge
it, even though you think it might be giving the wrong numbers,
because then someone might fix it.

otoh, if giving the wrong numbers leads to people's machines needlessly
shutting down or something like that, then that's not so good.

Opinions are sought?

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Michael Riepe <michael.riepe@googlemail.com>
Cc: linux-kernel@vger.kernel.org, Rudolf Marek <r.marek@assembler.cz>,
	lm-sensors@lm-sensors.org
Subject: Re: [PATCH] Enable coretemp driver on Intel Atom
Date: Thu, 18 Jun 2009 12:13:26 -0700	[thread overview]
Message-ID: <20090618121326.42ab9c2f.akpm@linux-foundation.org> (raw)
In-Reply-To: <49E7C34A.60007@googlemail.com>

On Fri, 17 Apr 2009 01:46:18 +0200
Michael Riepe <michael.riepe@googlemail.com> wrote:

> This small patch enables the coretemp driver on an Intel Atom. I'm not
> sure if the readings are correct, however - on my 330, the driver
> reports values between 27 and 41 __C (with core1 being about 8__C hotter
> than core0, given the same load). Maybe the maximum temperature of 100
> __C is wrong for Atom CPUs.
> 
> -- 
> Michael "Tired" Riepe <michael.riepe@googlemail.com>
> X-Tired: Each morning I get up I die a little
> 
> 
> [linux-2.6.29.1-coretemp-atom.diff  text/plain (916B)]
> Signed-off-by: Michael Riepe <michael.riepe@googlemail.com>
> 
> Index: drivers/hwmon/coretemp.c
> ===================================================================
> RCS file: /var/cvs/sys/kernel/linux-2.6/drivers/hwmon/coretemp.c,v
> retrieving revision 1.1.1.5
> diff -u -r1.1.1.5 coretemp.c
> --- drivers/hwmon/coretemp.c	11 Jan 2009 21:29:23 -0000	1.1.1.5
> +++ drivers/hwmon/coretemp.c	16 Apr 2009 23:02:40 -0000
> @@ -185,7 +185,7 @@
>  		}
>  	}
>  
> -	if (ismobile) {
> +	if (ismobile || c->x86_model == 0x1c) {
>  
>  		err = rdmsr_safe_on_cpu(id, 0xee, &eax, &edx);
>  		if (err) {
> @@ -417,7 +417,7 @@
>  		if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
>  		    !((c->x86_model == 0xe) || (c->x86_model == 0xf) ||
>  			(c->x86_model == 0x16) || (c->x86_model == 0x17) ||
> -			(c->x86_model == 0x1A))) {
> +			(c->x86_model == 0x1A) || (c->x86_model == 0x1c))) {
>  
>  			/* supported CPU not found, but report the unknown
>  			   family 6 CPU */
> 

I'm not 100% sure what to do about this patch.  I'm inclined to merge
it, even though you think it might be giving the wrong numbers,
because then someone might fix it.

otoh, if giving the wrong numbers leads to people's machines needlessly
shutting down or something like that, then that's not so good.

Opinions are sought?

  reply	other threads:[~2009-06-18 19:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 23:46 [PATCH] Enable coretemp driver on Intel Atom Michael Riepe
2009-06-18 19:13 ` Andrew Morton [this message]
2009-06-18 19:13   ` Andrew Morton
2009-06-18 21:05   ` [lm-sensors] " Michael Riepe
2009-06-18 21:05     ` Michael Riepe
2009-06-21 20:31     ` [lm-sensors] " Rudolf Marek
2009-06-21 20:31       ` Rudolf Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090618121326.42ab9c2f.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=michael.riepe@googlemail.com \
    --cc=r.marek@assembler.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.