From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
Carsten Otte <cotte@de.ibm.com>,
kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Glauber Costa <glommer@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv5 08/13] qemu: add support for resizing regions
Date: Thu, 18 Jun 2009 19:44:44 +0300 [thread overview]
Message-ID: <20090618164444.GB19553@redhat.com> (raw)
In-Reply-To: <200906181735.10458.paul@codesourcery.com>
On Thu, Jun 18, 2009 at 05:32:11PM +0100, Paul Brook wrote:
> On Thursday 18 June 2009, Michael S. Tsirkin wrote:
> > Make it possible to resize PCI regions. This will be used by virtio
> > with MSI-X, where the region size depends on whether MSI-X is enabled,
> > and can change across load/save.
>
> I thought we'd agreed we shouldn't be doing this.
> i.e. if the user tries to load the wrong device, just bail out.
>
> Paul
We need a way to generally prevent load from changing registers in a way
that can not be done by a guest. I haven't implemented this feature yet
though.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
kvm@vger.kernel.org, Glauber Costa <glommer@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
Blue Swirl <blauwirbel@gmail.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv5 08/13] qemu: add support for resizing regions
Date: Thu, 18 Jun 2009 19:44:44 +0300 [thread overview]
Message-ID: <20090618164444.GB19553@redhat.com> (raw)
In-Reply-To: <200906181735.10458.paul@codesourcery.com>
On Thu, Jun 18, 2009 at 05:32:11PM +0100, Paul Brook wrote:
> On Thursday 18 June 2009, Michael S. Tsirkin wrote:
> > Make it possible to resize PCI regions. This will be used by virtio
> > with MSI-X, where the region size depends on whether MSI-X is enabled,
> > and can change across load/save.
>
> I thought we'd agreed we shouldn't be doing this.
> i.e. if the user tries to load the wrong device, just bail out.
>
> Paul
We need a way to generally prevent load from changing registers in a way
that can not be done by a guest. I haven't implemented this feature yet
though.
--
MST
next prev parent reply other threads:[~2009-06-18 16:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1245330293.git.mst@redhat.com>
2009-06-18 13:12 ` [PATCHv5 01/13] qemu: make default_write_config use mask table Michael S. Tsirkin
2009-06-18 13:12 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:12 ` Michael S. Tsirkin
2009-06-18 13:13 ` [PATCHv5 02/13] qemu: capability bits in pci save/restore Michael S. Tsirkin
2009-06-18 13:13 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:13 ` Michael S. Tsirkin
2009-06-18 13:13 ` [PATCHv5 03/13] qemu: add routines to manage PCI capabilities Michael S. Tsirkin
2009-06-18 13:13 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:13 ` Michael S. Tsirkin
2009-06-18 13:13 ` [PATCHv5 04/13] qemu: helper routines for pci access Michael S. Tsirkin
2009-06-18 13:13 ` Michael S. Tsirkin
2009-06-18 13:13 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:13 ` [PATCHv5 05/13] qemu: MSI-X support functions Michael S. Tsirkin
2009-06-18 13:13 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:13 ` Michael S. Tsirkin
2009-06-18 13:14 ` [PATCHv5 06/13] qemu: add flag to disable MSI-X by default Michael S. Tsirkin
2009-06-18 13:14 ` Michael S. Tsirkin
2009-06-18 13:14 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:14 ` [PATCHv5 07/13] qemu: minimal MSI/MSI-X implementation for PC Michael S. Tsirkin
2009-06-18 13:14 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:14 ` Michael S. Tsirkin
2009-06-18 13:14 ` [PATCHv5 08/13] qemu: add support for resizing regions Michael S. Tsirkin
2009-06-18 13:14 ` Michael S. Tsirkin
2009-06-18 13:14 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 16:32 ` Paul Brook
2009-06-18 16:32 ` Paul Brook
2009-06-18 16:44 ` Michael S. Tsirkin [this message]
2009-06-18 16:44 ` Michael S. Tsirkin
2009-06-18 16:44 ` Michael S. Tsirkin
2009-06-18 16:32 ` Paul Brook
2009-06-18 13:14 ` [PATCHv5 09/13] qemu: virtio support for many interrupt vectors Michael S. Tsirkin
2009-06-18 13:14 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:14 ` Michael S. Tsirkin
2009-06-18 13:15 ` [PATCHv5 10/13] qemu: MSI-X support in virtio PCI Michael S. Tsirkin
2009-06-18 13:15 ` Michael S. Tsirkin
2009-06-18 13:15 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:15 ` [PATCHv5 11/13] qemu: request 3 vectors in virtio-net Michael S. Tsirkin
2009-06-18 13:15 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:15 ` Michael S. Tsirkin
2009-06-18 13:15 ` [PATCHv5 12/13] qemu: virtio save/load bindings Michael S. Tsirkin
2009-06-18 13:15 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-18 13:15 ` Michael S. Tsirkin
2009-06-18 13:15 ` [PATCHv5 13/13] qemu: add pci_get/set_byte Michael S. Tsirkin
2009-06-18 13:15 ` Michael S. Tsirkin
2009-06-18 13:15 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090618164444.GB19553@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.