Re: [Qemu-devel] [PATCH v4] avoid compilation warning/errors on up to date

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 18 Jun 2009 15:33:03 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:

> Luiz Capitulino wrote:
> > On Thu, 18 Jun 2009 01:16:37 +0200
> > "Jean-Christophe Dubois" <jcd@tribudubois.net> wrote:
> >
> >   
> >> And whatever I have added is a lot more robust than what was
> >> before. Once again, please just show me where my patch is
> >> incorrect and I will fix it. 
> >>     
> >
> >  I really missed this v4, sorry for that and thanks for letting me
> > know.
> >
> >  I think the first step is to do one logical change at a time. You
> > could, for example do:
> >
> >  1. Add qemu_read() and qemu_write()
> >   
> 
> We already have these in various places.  The problem is, we often
> want different semantics.  We don't always want to retry partial
> results (like for live migration).  We need a more rationalized
> approach to this.

 If a reasonable number of users can agree on one general semantic,
we could have qemu_read() for it and let the others use plain read()
directly.

 But now I'm guessing, one should map all the usage to have a better
picture on how to encapsulate and share code.

 And I hope this is done before having anything merged, otherwise
this will require the same amount of work later.