All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] avoid compilation warning/errors on up to date
Date: Wed, 17 Jun 2009 17:51:43 -0500	[thread overview]
Message-ID: <4A39737F.7070101@codemonkey.ws> (raw)
In-Reply-To: <200906180041.31816.jcd@tribudubois.net>

Jean-Christophe Dubois wrote:
> Once again, when all warnings are suppressed I doubt anybody will volunteer 
> for this boring task. And all future code added to the project without system 
> call error check will get unnoticed because you silenced GCC.
>
> But at the end it is your call.
>   

Silencing the warnings != fixing the warnings.

To fix the warning, the errors have to be dealt with in a graceful way.  
This means either propagating the errors and releases any acquired 
resources or aborting.

It is not an improvement to just add dummy error handling in a few 
spots.  It does not result in making the code any more robust.

Regards,

Anthony Liguori

>> Regards,
>>
>> Anthony Liguori
>>     
>
>   

  reply	other threads:[~2009-06-17 22:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 21:22 [Qemu-devel] [PATCH v4] avoid compilation warning/errors on up to date Jean-Christophe Dubois
2009-06-17 21:51 ` malc
2009-06-17 22:58   ` Jean-Christophe Dubois
2009-06-18  1:17     ` malc
2009-06-17 21:54 ` Anthony Liguori
2009-06-17 22:41   ` Jean-Christophe Dubois
2009-06-17 22:51     ` Anthony Liguori [this message]
2009-06-17 23:16       ` Jean-Christophe Dubois
2009-06-18 20:16         ` Luiz Capitulino
2009-06-18 20:33           ` Anthony Liguori
2009-06-18 21:05             ` Luiz Capitulino
2009-06-18 21:10             ` Jean-Christophe Dubois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A39737F.7070101@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jcd@tribudubois.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.