Re: [PATCH] Use kzalloc for frontend states to have struct dvb_frontend properly initialized

[Matthias Schwarzott <zzam@gentoo.org>]

On Freitag, 19. Juni 2009, Andreas Oberritter wrote:
> Hello Matthias,
>
> Matthias Schwarzott wrote:
> > This patch changes most frontend drivers to allocate their state
> > structure via kzalloc and not kmalloc. This is done to properly
> > initialize the embedded "struct dvb_frontend frontend" field, that they
> > all have.
> >
> > The visible effect of this struct being uninitalized is, that the member
> > "id" that is used to set the name of kernel thread is totally random.
> >
> > [...]
> >
> > Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
>
> I still think that this id doesn't belong into struct dvb_frontend and
> should be private to the drivers, but using kzalloc is a good idea in
> every case. Did you verify that none of the drivers does an additional
> memset?
Yes, I did verify that. There are no memset calls for that memory.

> If so, you can add my "Acked-by: Andreas Oberritter 
> <obi@linuxtv.org>".
>
Regards
Matthias