Re: [PATCH] Use kzalloc for frontend states to have struct dvb_frontend properly initialized

[Andreas Oberritter <obi@linuxtv.org>]

Hello Matthias,

Matthias Schwarzott wrote:
> This patch changes most frontend drivers to allocate their state structure via 
> kzalloc and not kmalloc. This is done to properly initialize the 
> embedded "struct dvb_frontend frontend" field, that they all have.
> 
> The visible effect of this struct being uninitalized is, that the member "id" 
> that is used to set the name of kernel thread is totally random.
> 
> Some board drivers (for example cx88-dvb) set this "id" via 
> videobuf_dvb_alloc_frontend but most do not.
> 
> So I at least get random id values for saa7134, flexcop and ttpci based cards. 
> It looks like this in dmesg:
> DVB: registering adapter 1 frontend -10551321 (ST STV0299 DVB-S)
> 
> The related kernel thread then also gets a strange name 
> like "kdvb-ad-1-fe--1".
> 
> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>

I still think that this id doesn't belong into struct dvb_frontend and
should be private to the drivers, but using kzalloc is a good idea in
every case. Did you verify that none of the drivers does an additional
memset? If so, you can add my "Acked-by: Andreas Oberritter
<obi@linuxtv.org>".

Regards,
Andreas