All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>, ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] xfstests: basic fallocate boundary tests
Date: Sat, 20 Jun 2009 13:58:24 -0400	[thread overview]
Message-ID: <20090620175824.GA3984@infradead.org> (raw)
In-Reply-To: <4A370C2C.6030404@sandeen.net>

On Mon, Jun 15, 2009 at 10:06:20PM -0500, Eric Sandeen wrote:
> This is just like test 072, but using fallocate instead
> of the xfs ioctl.  Just very basic fallocate tests.
> 
> Also adds a "prealloc" group (./check -g prealloc)

Looks good to me, and does the right thing on my 32 bit test VM (notrun)

> +echo $testio | grep -q "not found" && \
> +	_notrun "xfs_io fallocate support is missing"
> +echo $testio | grep -q "Operation not supported" && \
> +	_notrun "xfs_io fallocate command failed (old kernel? wrong fs?)"

Maybe add a _require_fallocate as you need the same check in the next
testcase?


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: ext4 development <linux-ext4@vger.kernel.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/3] xfstests: basic fallocate boundary tests
Date: Sat, 20 Jun 2009 13:58:24 -0400	[thread overview]
Message-ID: <20090620175824.GA3984@infradead.org> (raw)
In-Reply-To: <4A370C2C.6030404@sandeen.net>

On Mon, Jun 15, 2009 at 10:06:20PM -0500, Eric Sandeen wrote:
> This is just like test 072, but using fallocate instead
> of the xfs ioctl.  Just very basic fallocate tests.
> 
> Also adds a "prealloc" group (./check -g prealloc)

Looks good to me, and does the right thing on my 32 bit test VM (notrun)

> +echo $testio | grep -q "not found" && \
> +	_notrun "xfs_io fallocate support is missing"
> +echo $testio | grep -q "Operation not supported" && \
> +	_notrun "xfs_io fallocate command failed (old kernel? wrong fs?)"

Maybe add a _require_fallocate as you need the same check in the next
testcase?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-06-20 17:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  3:06 [PATCH 1/3] xfstests: basic fallocate boundary tests Eric Sandeen
2009-06-20 17:58 ` Christoph Hellwig [this message]
2009-06-20 17:58   ` Christoph Hellwig
2009-06-20 21:33   ` Eric Sandeen
2009-06-20 21:33     ` Eric Sandeen
2009-06-21 19:16     ` Christoph Hellwig
2009-06-21 19:16       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090620175824.GA3984@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.