From: Marcelo Tosatti <mtosatti@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <marcelo@kvack.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] kvm: change memslot data structures for multiple hugepage sizes
Date: Tue, 23 Jun 2009 13:49:20 -0300 [thread overview]
Message-ID: <20090623164920.GC3651@amt.cnet> (raw)
In-Reply-To: <1245417389-5527-3-git-send-email-joerg.roedel@amd.com>
On Fri, Jun 19, 2009 at 03:16:23PM +0200, Joerg Roedel wrote:
> /*
> @@ -724,11 +724,11 @@ static int kvm_handle_hva(struct kvm *kvm, unsigned long hva,
> end = start + (memslot->npages << PAGE_SHIFT);
> if (hva >= start && hva < end) {
> gfn_t gfn_offset = (hva - start) >> PAGE_SHIFT;
> + int idx = gfn_offset /
> + KVM_PAGES_PER_HPAGE(PT_DIRECTORY_LEVEL);
> retval |= handler(kvm, &memslot->rmap[gfn_offset]);
> retval |= handler(kvm,
> - &memslot->lpage_info[
> - gfn_offset /
> - KVM_PAGES_PER_HPAGE].rmap_pde);
> + &memslot->lpage_info[0][idx].rmap_pde);
> }
Cannot find where you update this function to reflect 1GB pages in the
series?
next prev parent reply other threads:[~2009-06-23 16:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 13:16 [PATCH 0/8 v3] KVM support for 1GB pages Joerg Roedel
2009-06-19 13:16 ` [PATCH 1/8] hugetlbfs: export vma_kernel_pagsize to modules Joerg Roedel
2009-06-19 13:16 ` [PATCH 2/8] kvm: change memslot data structures for multiple hugepage sizes Joerg Roedel
2009-06-23 16:49 ` Marcelo Tosatti [this message]
2009-06-19 13:16 ` [PATCH 3/8] kvm/mmu: rename is_largepage_backed to mapping_level Joerg Roedel
2009-06-23 15:59 ` Marcelo Tosatti
2009-06-23 17:00 ` Joerg Roedel
2009-06-19 13:16 ` [PATCH 4/8] kvm/mmu: make rmap code aware of mapping levels Joerg Roedel
2009-06-19 13:16 ` [PATCH 5/8] kvm/mmu: make direct mapping paths " Joerg Roedel
2009-06-23 16:47 ` Marcelo Tosatti
2009-06-23 17:10 ` Joerg Roedel
2009-06-19 13:16 ` [PATCH 6/8] kvm/mmu: add support for another level to page walker Joerg Roedel
2009-06-20 11:19 ` Avi Kivity
2009-06-22 9:38 ` Joerg Roedel
2009-06-19 13:16 ` [PATCH 7/8] kvm/mmu: enable gbpages by increasing nr of pagesizes Joerg Roedel
2009-06-19 13:16 ` [PATCH 8/8] kvm x86: report 1GB page support to userspace Joerg Roedel
2009-06-20 11:03 ` [PATCH 0/8 v3] KVM support for 1GB pages Avi Kivity
2009-06-22 9:40 ` Joerg Roedel
2009-06-22 9:43 ` Avi Kivity
2009-06-22 9:49 ` Joerg Roedel
2009-06-22 9:55 ` Avi Kivity
2009-06-24 8:43 ` Avi Kivity
2009-06-29 13:17 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623164920.GC3651@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.