From: Andrew Morton <akpm@linux-foundation.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org,
Gerard Lledo <gerard.lledo@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [JFFS2] jffs2_start_garbage_collect_thread() return value cleanup
Date: Wed, 24 Jun 2009 20:00:29 -0700 [thread overview]
Message-ID: <20090624200029.d875c48e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1245838141.25547.5207.camel@macbook.infradead.org>
On Wed, 24 Jun 2009 11:09:01 +0100 David Woodhouse <dwmw2@infradead.org> wrote:
> On Tue, 2009-06-02 at 15:11 +0300, Gerard Lledo wrote:
> > There is no user of this return value in the kernel. Change it to return void
> > instead.
>
> NAK. I hate this type of patch.
>
> A function _should_ return an error value indicating success or failure,
> if there's _any_ chance that it (or a future rewrite of it) may fail.
>
> It's up to the _callers_ to act on that result, or not, as they see fit.
True.
> Andrew, may I suggest that you look for such justification in future
> patches of this type?
eh, I sometimes don't even look at them. I just save them up in case of
maintainer fumblage.
I might retain this one as a "jffs2 fails to check
jffs2_start_garbage_collect_thread() return value" bug report :)
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Gerard Lledo <gerard.lledo@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [JFFS2] jffs2_start_garbage_collect_thread() return value cleanup
Date: Wed, 24 Jun 2009 20:00:29 -0700 [thread overview]
Message-ID: <20090624200029.d875c48e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1245838141.25547.5207.camel@macbook.infradead.org>
On Wed, 24 Jun 2009 11:09:01 +0100 David Woodhouse <dwmw2@infradead.org> wrote:
> On Tue, 2009-06-02 at 15:11 +0300, Gerard Lledo wrote:
> > There is no user of this return value in the kernel. Change it to return void
> > instead.
>
> NAK. I hate this type of patch.
>
> A function _should_ return an error value indicating success or failure,
> if there's _any_ chance that it (or a future rewrite of it) may fail.
>
> It's up to the _callers_ to act on that result, or not, as they see fit.
True.
> Andrew, may I suggest that you look for such justification in future
> patches of this type?
eh, I sometimes don't even look at them. I just save them up in case of
maintainer fumblage.
I might retain this one as a "jffs2 fails to check
jffs2_start_garbage_collect_thread() return value" bug report :)
next prev parent reply other threads:[~2009-06-25 3:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 8:19 [PATCH] [JFFS2] Move jffs2_gcd_mtd threads to the new kthread API Gerard Lledo
2009-05-29 8:19 ` Gerard Lledo
2009-05-29 8:19 ` Gerard Lledo
2009-06-01 23:20 ` [PATCH] [JFFS2] Move jffs2_gcd_mtd threads to the new kthread Andrew Morton
2009-06-01 23:20 ` [PATCH] [JFFS2] Move jffs2_gcd_mtd threads to the new kthread API Andrew Morton
2009-06-01 23:20 ` Andrew Morton
2009-06-02 11:32 ` [PATCH] [JFFS2] Move jffs2_gcd_mtd threads to the new kthread Gerard Lledo
2009-06-02 11:32 ` [PATCH] [JFFS2] Move jffs2_gcd_mtd threads to the new kthread API Gerard Lledo
2009-06-02 11:32 ` Gerard Lledo
2009-06-02 12:11 ` Gerard Lledo
2009-06-02 12:11 ` Gerard Lledo
2009-06-02 12:11 ` [PATCH] [JFFS2] jffs2_start_garbage_collect_thread() return value cleanup Gerard Lledo
2009-06-02 12:11 ` Gerard Lledo
2009-06-02 22:11 ` Andrew Morton
2009-06-02 22:11 ` Andrew Morton
2009-06-03 6:09 ` Gerard Lledo
2009-06-03 6:09 ` Gerard Lledo
2009-06-24 10:09 ` David Woodhouse
2009-06-25 3:00 ` Andrew Morton [this message]
2009-06-25 3:00 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624200029.d875c48e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=gerard.lledo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.