From: Christoph Hellwig <hch@lst.de>
To: G 3 <programmingkidx@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Substitute O_SYNC with O_FSYNC in block/raw-posix.c
Date: Fri, 26 Jun 2009 19:55:38 +0200 [thread overview]
Message-ID: <20090626175538.GA4077@lst.de> (raw)
In-Reply-To: <a8d88129bff47f8006a614998b63b302@gmail.com>
On Thu, Jun 25, 2009 at 08:59:35PM -0400, G 3 wrote:
> This patch will allow the file block/raw-posix.c to compile on gcc 3.3
> on Mac OS 10.3. Since the O_SYNC symbol is missing on this version of
> the Mac OS, O_FSYNC will be used in its place.
Same comment about the zero as last time still applies. Also the
look of this is really ugly as you just deinfe O_SYNC only for it
to substitute for O_DSYNC a littler later, with two comments that
together are rather confusing about macos..
next prev parent reply other threads:[~2009-06-26 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 0:59 [Qemu-devel] [PATCH] Substitute O_SYNC with O_FSYNC in block/raw-posix.c G 3
2009-06-26 17:55 ` Christoph Hellwig [this message]
[not found] ` <3b18e1127cac98f7cacb6cca22fed96e@gmail.com>
[not found] ` <20090701135404.GB16868@lst.de>
2009-07-01 17:28 ` [Qemu-devel] [PATCH] Substitute O_DSYNC with O_SYNC or O_FSYNC when needed G 3
2009-07-02 8:48 ` [Qemu-devel] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090626175538.GA4077@lst.de \
--to=hch@lst.de \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.