All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: G 3 <programmingkidx@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Substitute O_DSYNC with O_SYNC or O_FSYNC when needed.
Date: Thu, 2 Jul 2009 10:48:48 +0200	[thread overview]
Message-ID: <20090702084848.GA32699@lst.de> (raw)
In-Reply-To: <45f1eeaa1ea123585c41d07c49584ead@gmail.com>

On Wed, Jul 01, 2009 at 01:28:32PM -0400, G 3 wrote:
> This patch should be what you want.
> 
> commit b32354139556d1a807d04aa54ed82610e0f4507a
> Author: John Arbuckle <programmingkidx@gmail.com>
> Date:   Wed Jul 1 13:24:37 2009 -0400
> 
>     Substitute O_DSYNC with O_SYNC or O_FSYNC when needed.
> 
>     Signed-off-by: John Arbuckle <programmingkidx@gmail.com>

Thanks, looks good to me,


Reviewed-by: Christoph Hellwig <hch@lst.de>

> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 8b1e67c..17338ee 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -81,7 +81,11 @@
> 
>  /* OS X does not have O_DSYNC */
>  #ifndef O_DSYNC
> +#ifdef O_SYNC
>  #define O_DSYNC O_SYNC
> +#elif defined(O_FSYNC)
> +#define O_DSYNC O_FSYNC
> +#endif
>  #endif
---end quoted text---

      reply	other threads:[~2009-07-02  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-26  0:59 [Qemu-devel] [PATCH] Substitute O_SYNC with O_FSYNC in block/raw-posix.c G 3
2009-06-26 17:55 ` Christoph Hellwig
     [not found]   ` <3b18e1127cac98f7cacb6cca22fed96e@gmail.com>
     [not found]     ` <20090701135404.GB16868@lst.de>
2009-07-01 17:28       ` [Qemu-devel] [PATCH] Substitute O_DSYNC with O_SYNC or O_FSYNC when needed G 3
2009-07-02  8:48         ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090702084848.GA32699@lst.de \
    --to=hch@lst.de \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.