All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: Felix Zielcke <fzielcke@z-51.de>
Cc: grub-devel@gnu.org
Subject: Re: [2338] 2009-06-17  Felix Zielcke  <fzielcke@z-51.de>
Date: Sun, 28 Jun 2009 13:44:08 +0200	[thread overview]
Message-ID: <20090628114408.GE16893@thorin> (raw)
In-Reply-To: <1246184616.3478.1.camel@fz.local>

On Sun, Jun 28, 2009 at 12:23:36PM +0200, Felix Zielcke wrote:
> Am Samstag, den 20.06.2009, 15:43 +0200 schrieb Robert Millan:
> > Hi Felix,
> > 
> > This commit looks wrong.  grub_file_open is already supposed to set
> > grub_errno and grub_errmsg appropiately.
> > 
> > Is there a specific problem you wanted to fix here?
> 
> If the loaded file can't be found, the menuentry code just continuesa
> and initrd then complains that you must load the kernel first.

Thanks.  Looking at the patch, the only possible explanation for this is that
grub_file_open() returned 0 but didn't set grub_errno.

I'll try to find a moment to debug this.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



      reply	other threads:[~2009-06-28 11:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1MGynD-0005z5-PM@cvs.savannah.gnu.org>
2009-06-20 13:43 ` [2338] 2009-06-17 Felix Zielcke <fzielcke@z-51.de> Robert Millan
2009-06-27 12:22   ` Robert Millan
2009-06-28 10:23   ` Felix Zielcke
2009-06-28 11:44     ` Robert Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090628114408.GE16893@thorin \
    --to=rmh@aybabtu.com \
    --cc=fzielcke@z-51.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.