All of lore.kernel.org
 help / color / mirror / Atom feed
From: Walther Maldonado <walther.maldonado@unine.ch>
To: <kvm@vger.kernel.org>
Subject: BUG Report: "config KVM" selects PREEMPT_NOTIFIERS, but it should also select PREEMPT (Vanilla Kernel 2.6.30)
Date: Mon, 29 Jun 2009 17:18:55 +0200	[thread overview]
Message-ID: <20090629171855.2820e75a@Xellex> (raw)

Good day,

Today when attempting to compile and install the KVM module (kernel 2.6.30), inserting the module would error with a number of unresolved symbols such as preempt_notifier_register() not found.

Some code-browsing revealed that, even though the kvm KConfig setting "KVM" does select PREEMPT_NOTIFIERS, in include/linux/preempt.h, said define will not cause the expected functions to be defined unless CONFIG_PREEMPT is also selected.

But I don't have CONFIG_PREEMPT (Preemptible Kernel), my kernel was configured with CONFIG_PREEMPT_VOLUNTARY (Voluntary Kernel Preemption). Since the define CONFIG_PREEMPT_NOTIFIERS is used in other files other than preempt.h, the bug might be in KVM's Kconfig file (in my case, arch/x86/kConfig) not selecting/depending on the right config parameters.

Cheers,
Walther

PS: If there is a need to reply, please do so directly as I am not subscribed to the mailing list.


             reply	other threads:[~2009-06-29 23:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-29 15:18 Walther Maldonado [this message]
2009-07-01  9:41 ` BUG Report: "config KVM" selects PREEMPT_NOTIFIERS, but it should also select PREEMPT (Vanilla Kernel 2.6.30) Avi Kivity
2009-07-01 13:29   ` Walther Maldonado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090629171855.2820e75a@Xellex \
    --to=walther.maldonado@unine.ch \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.