All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Walther Maldonado <walther.maldonado@unine.ch>
Cc: kvm@vger.kernel.org
Subject: Re: BUG Report: "config KVM" selects PREEMPT_NOTIFIERS, but it should also select PREEMPT (Vanilla Kernel 2.6.30)
Date: Wed, 01 Jul 2009 12:41:38 +0300	[thread overview]
Message-ID: <4A4B2F52.3080506@redhat.com> (raw)
In-Reply-To: <20090629171855.2820e75a@Xellex>

On 06/29/2009 06:18 PM, Walther Maldonado wrote:
> Good day,
>
> Today when attempting to compile and install the KVM module (kernel 2.6.30), inserting the module would error with a number of unresolved symbols such as preempt_notifier_register() not found.
>
> Some code-browsing revealed that, even though the kvm KConfig setting "KVM" does select PREEMPT_NOTIFIERS, in include/linux/preempt.h, said define will not cause the expected functions to be defined unless CONFIG_PREEMPT is also selected.
>
>    

Not in my copy of v2.6.30.  preempt.h only guards the preempt notifier 
symbols with CONFIG_PREEMPT_NOTIFIER.

I built sched.o with CONFIG_PREEMPT_NONE=y and see:

[avi@cleopatra linux-2.6 (v2.6.30)]$ nm kernel/sched.o  | grep 
preempt_notifier
00000000c559bf4c A __crc_preempt_notifier_register
000000008be61cbb A __crc_preempt_notifier_unregister
0000000000000028 r __kcrctab_preempt_notifier_register
0000000000000020 r __kcrctab_preempt_notifier_unregister
0000000000000232 r __kstrtab_preempt_notifier_register
0000000000000216 r __kstrtab_preempt_notifier_unregister
0000000000000050 r __ksymtab_preempt_notifier_register
0000000000000040 r __ksymtab_preempt_notifier_unregister
0000000000000c77 T preempt_notifier_register
0000000000000caf T preempt_notifier_unregister

Perhaps you have a stale kernel installed?  Try reinstalling the kernel 
and modules and rebooting.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-07-01  9:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-29 15:18 BUG Report: "config KVM" selects PREEMPT_NOTIFIERS, but it should also select PREEMPT (Vanilla Kernel 2.6.30) Walther Maldonado
2009-07-01  9:41 ` Avi Kivity [this message]
2009-07-01 13:29   ` Walther Maldonado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4B2F52.3080506@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=walther.maldonado@unine.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.