All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Egger <Christoph.Egger@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] buildfix: unknown option	"-Wno-error=uninitialized"
Date: Tue, 30 Jun 2009 12:14:42 +0200	[thread overview]
Message-ID: <200906301214.42875.Christoph.Egger@amd.com> (raw)
In-Reply-To: <4A49E365.40307@redhat.com>

On Tuesday 30 June 2009 12:05:25 Avi Kivity wrote:
> On 06/30/2009 12:15 PM, Christoph Egger wrote:
> > diff --git a/rules.mak b/rules.mak
> > index defee1d..8561289 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -1,6 +1,6 @@
> >
> >   %.o: %.c
> > -	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror
> > -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@") +	$(call
> > quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -c -o $@ $<,"  CC   
> > $(TARGET_DIR)$@")
> >
> >   %.o: %.S
> >   	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,"  AS   
> > $(TARGET_DIR)$@")
>
> Should remove the -Werror too, it's set by ./configure.

Will you do this between applying the patch and 'git commit' or should I 
resend a diff ?

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2009-06-30 10:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30  9:15 [Qemu-devel] [PATCH] buildfix: unknown option "-Wno-error=uninitialized" Christoph Egger
2009-06-30 10:05 ` Avi Kivity
2009-06-30 10:14   ` Christoph Egger [this message]
2009-06-30 10:20     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906301214.42875.Christoph.Egger@amd.com \
    --to=christoph.egger@amd.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.