All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Egger <Christoph.Egger@amd.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64
Date: Tue, 30 Jun 2009 15:13:11 +0200	[thread overview]
Message-ID: <200906301513.12043.Christoph.Egger@amd.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]


Hi!

Attached patch fixes this build error on NetBSD/amd64:

hw/xen_blkif.h:20: warning: #pragma pack(psuh[, id], <n>) is not supported on 
this target
hw/xen_blkif.h:36: warning: #pragma pack(pop[, id], <n>) is not supported on 
this target

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: qemu_xen_blkif.diff --]
[-- Type: text/x-diff, Size: 1243 bytes --]

diff --git a/hw/xen_blkif.h b/hw/xen_blkif.h
index 738b8fe..bb4ff02 100644
--- a/hw/xen_blkif.h
+++ b/hw/xen_blkif.h
@@ -16,8 +16,9 @@ struct blkif_common_response {
 	char dummy;
 };
 
+/* XXX move this into a proper header */
+#define __aligned(x)	__attribute__((__aligned__(x)))
 /* i386 protocol version */
-#pragma pack(push, 4)
 struct blkif_x86_32_request {
 	uint8_t        operation;    /* BLKIF_OP_???                         */
 	uint8_t        nr_segments;  /* number of segments                   */
@@ -25,15 +26,14 @@ struct blkif_x86_32_request {
 	uint64_t       id;           /* private guest value, echoed in resp  */
 	blkif_sector_t sector_number;/* start sector idx on disk (r/w only)  */
 	struct blkif_request_segment seg[BLKIF_MAX_SEGMENTS_PER_REQUEST];
-};
+} __aligned(4);
 struct blkif_x86_32_response {
 	uint64_t        id;              /* copied from request */
 	uint8_t         operation;       /* copied from request */
 	int16_t         status;          /* BLKIF_RSP_???       */
-};
+} __aligned(4);
 typedef struct blkif_x86_32_request blkif_x86_32_request_t;
 typedef struct blkif_x86_32_response blkif_x86_32_response_t;
-#pragma pack(pop)
 
 /* x86_64 protocol version */
 struct blkif_x86_64_request {

             reply	other threads:[~2009-06-30 13:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 13:13 Christoph Egger [this message]
2009-07-09 19:21 ` [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64 Anthony Liguori
2009-07-10  8:19   ` Christoph Egger
2009-07-10 10:18     ` malc
2009-07-10 12:36       ` Christoph Egger
2009-07-10 15:22         ` malc
2009-07-17 13:28           ` Christoph Egger
2009-07-17 16:58             ` malc
2009-07-10 12:58     ` Anthony Liguori
2009-07-10 13:20       ` Christoph Egger
2009-07-10 15:24         ` malc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906301513.12043.Christoph.Egger@amd.com \
    --to=christoph.egger@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.