All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64
Date: Fri, 10 Jul 2009 07:58:48 -0500	[thread overview]
Message-ID: <4A573B08.9010903@codemonkey.ws> (raw)
In-Reply-To: <200907101019.31977.Christoph.Egger@amd.com>

Christoph Egger wrote:
> On Thursday 09 July 2009 21:21:06 Anthony Liguori wrote:
>   
>> Christoph Egger wrote:
>>     
>>> Hi!
>>>
>>> Attached patch fixes this build error on NetBSD/amd64:
>>>
>>> hw/xen_blkif.h:20: warning: #pragma pack(psuh[, id], <n>) is not
>>> supported on this target
>>> hw/xen_blkif.h:36: warning: #pragma pack(pop[, id], <n>) is not supported
>>> on this target
>>>
>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>       
>> You'll invoke the fury of malc for introducing an identifier that begins
>> with '__' :-)
>>     
>
> In NetBSD, there is this in <sys/cdefs.h> :
>   

NetBSD is allowed to use these names in system headers but according to 
the C standard, normal programs like QEMU aren't.  So we need to use 
something other than __aligned.

Regards,

Anthony Liguori

  parent reply	other threads:[~2009-07-10 12:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 13:13 [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64 Christoph Egger
2009-07-09 19:21 ` Anthony Liguori
2009-07-10  8:19   ` Christoph Egger
2009-07-10 10:18     ` malc
2009-07-10 12:36       ` Christoph Egger
2009-07-10 15:22         ` malc
2009-07-17 13:28           ` Christoph Egger
2009-07-17 16:58             ` malc
2009-07-10 12:58     ` Anthony Liguori [this message]
2009-07-10 13:20       ` Christoph Egger
2009-07-10 15:24         ` malc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A573B08.9010903@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Christoph.Egger@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.