From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/8] qdev/core: bus list
Date: Wed, 1 Jul 2009 01:29:41 +0100 [thread overview]
Message-ID: <200907010129.42401.paul@codesourcery.com> (raw)
In-Reply-To: <873a9hw9ak.fsf@pike.pond.sub.org>
> >>> The address of the BusState is also a locally unique
> >>> identifier. That doesn't mean it's a good thing to expose to the
> >>> user.
> >>
> >> Red herring.
> >
> > I don't think that's a very useful response.
> >
> > I think it's a perfectly valid suggestion that we should identify
> > buses based on the their location in the tree to users verses a number
> > generated based on some hashing algorithm.
> >
> > A tree location has meaning to a user. A random integer doesn't.
>
> Numbering nodes according to a well-defined tree traversal is not
> random. We can discuss whether using such a number in an interface is a
> good idea (nobody suggested to use it *instead* of tree paths).
I don't believe the tree traversal order is well defined. While developing the
qdev patches I went through two or three different traversal algorithms. It
gets even hairier when you start considering hotplug.
Paul
next prev parent reply other threads:[~2009-07-01 0:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 9:25 [Qemu-devel] [PATCH 0/7] qdev patches, batch #1 Gerd Hoffmann
2009-06-30 9:25 ` [Qemu-devel] [PATCH 1/8] qdev: update pci device registration Gerd Hoffmann
2009-06-30 9:25 ` [Qemu-devel] [PATCH 2/8] qdev: replace bus_type enum with bus_info struct Gerd Hoffmann
2009-06-30 9:25 ` [Qemu-devel] [PATCH 3/8] qdev: remove DeviceType Gerd Hoffmann
2009-06-30 9:25 ` [Qemu-devel] [PATCH 4/8] qdev/core: bus list Gerd Hoffmann
2009-06-30 11:18 ` Paul Brook
2009-06-30 16:55 ` Markus Armbruster
2009-06-30 17:21 ` Paul Brook
2009-06-30 19:26 ` Markus Armbruster
2009-06-30 19:49 ` Anthony Liguori
2009-06-30 20:18 ` Gerd Hoffmann
2009-06-30 20:36 ` Anthony Liguori
2009-07-01 0:25 ` Paul Brook
2009-07-01 6:32 ` Gerd Hoffmann
2009-07-01 0:12 ` Markus Armbruster
2009-07-01 0:29 ` Paul Brook [this message]
2009-06-30 9:25 ` [Qemu-devel] [PATCH 5/8] qdev/core: add monitor command to list all drivers Gerd Hoffmann
2009-06-30 9:26 ` [Qemu-devel] [PATCH 6/8] qdev/pci: misc fixes Gerd Hoffmann
2009-06-30 11:25 ` Paul Brook
2009-06-30 16:51 ` Markus Armbruster
2009-06-30 9:26 ` [Qemu-devel] [PATCH 7/8] qdev: convert es1370 Gerd Hoffmann
2009-06-30 9:26 ` [Qemu-devel] [PATCH 8/8] qdev: convert ac97 Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907010129.42401.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.