All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/8] qdev/pci: misc fixes.
Date: Tue, 30 Jun 2009 18:51:33 +0200	[thread overview]
Message-ID: <87ocs58y22.fsf@pike.pond.sub.org> (raw)
In-Reply-To: <200906301225.23268.paul@codesourcery.com> (Paul Brook's message of "Tue\, 30 Jun 2009 12\:25\:22 +0100")

Paul Brook <paul@codesourcery.com> writes:

> On Tuesday 30 June 2009, Gerd Hoffmann wrote:
>> -    register_savevm("PCIBUS", nbus++, 1, pcibus_save, pcibus_load, bus);
>> +    register_savevm("PCIBUS", bus->qbus.busnr, 1, pcibus_save,
>> pcibus_load, bus);
>
> This is wrong. In principle there may be many different PCI domains with 
> overlapping bus numbers.
>
> Paul

We don't support multiple PCI domains, so this is fine for now.  When we
do, we can simply prepend the 16 bit PCI domain number to the 8 bit PCI
bus number.

  reply	other threads:[~2009-06-30 16:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30  9:25 [Qemu-devel] [PATCH 0/7] qdev patches, batch #1 Gerd Hoffmann
2009-06-30  9:25 ` [Qemu-devel] [PATCH 1/8] qdev: update pci device registration Gerd Hoffmann
2009-06-30  9:25 ` [Qemu-devel] [PATCH 2/8] qdev: replace bus_type enum with bus_info struct Gerd Hoffmann
2009-06-30  9:25 ` [Qemu-devel] [PATCH 3/8] qdev: remove DeviceType Gerd Hoffmann
2009-06-30  9:25 ` [Qemu-devel] [PATCH 4/8] qdev/core: bus list Gerd Hoffmann
2009-06-30 11:18   ` Paul Brook
2009-06-30 16:55     ` Markus Armbruster
2009-06-30 17:21       ` Paul Brook
2009-06-30 19:26         ` Markus Armbruster
2009-06-30 19:49           ` Anthony Liguori
2009-06-30 20:18             ` Gerd Hoffmann
2009-06-30 20:36               ` Anthony Liguori
2009-07-01  0:25               ` Paul Brook
2009-07-01  6:32                 ` Gerd Hoffmann
2009-07-01  0:12             ` Markus Armbruster
2009-07-01  0:29               ` Paul Brook
2009-06-30  9:25 ` [Qemu-devel] [PATCH 5/8] qdev/core: add monitor command to list all drivers Gerd Hoffmann
2009-06-30  9:26 ` [Qemu-devel] [PATCH 6/8] qdev/pci: misc fixes Gerd Hoffmann
2009-06-30 11:25   ` Paul Brook
2009-06-30 16:51     ` Markus Armbruster [this message]
2009-06-30  9:26 ` [Qemu-devel] [PATCH 7/8] qdev: convert es1370 Gerd Hoffmann
2009-06-30  9:26 ` [Qemu-devel] [PATCH 8/8] qdev: convert ac97 Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocs58y22.fsf@pike.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.