From: Frans Englich <fenglich@fastmail.fm>
To: git@vger.kernel.org
Subject: Bug report: .gitattributes: -diff Unset causes files to be reported as binaries
Date: Wed, 1 Jul 2009 12:08:35 +0200 [thread overview]
Message-ID: <200907011208.35397.fenglich@fastmail.fm> (raw)
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
Hi,
Applying -diff Unset to a file using .gittattributes causes "git diff" to
state that the file is a binary even though it isn't, or have been instructed
to be treated as one. See attached script for reproducing.
This causes confusion since the file isn't a binary, it's only the diff output
that has been suppressed. For instance, an auto generated cpp file has -diff
Unset applied to it to suppress the meaningless output, but people contact
you to point out the file is binary.
Perhaps this is easy to fix, a question of changing message strings.
Cheers,
Frans
[-- Attachment #2: reproduceDiffBinary.sh --]
[-- Type: application/x-shellscript, Size: 365 bytes --]
next reply other threads:[~2009-07-01 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 10:08 Frans Englich [this message]
2009-07-02 5:35 ` Bug report: .gitattributes: -diff Unset causes files to be reported as binaries Jeff King
2009-07-02 8:14 ` Frans Englich
2009-07-02 11:12 ` Paolo Bonzini
2009-07-02 11:29 ` Frans Englich
2009-07-02 11:29 ` Paolo Bonzini
2009-07-02 17:05 ` Jeff King
2009-07-02 11:59 ` Jakub Narebski
2009-07-02 17:04 ` Jeff King
2009-07-02 14:29 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907011208.35397.fenglich@fastmail.fm \
--to=fenglich@fastmail.fm \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.