All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <paolo.bonzini@gmail.com>
To: Frans Englich <fenglich@fastmail.fm>
Cc: Paolo Bonzini <bonzini@gnu.org>, Jeff King <peff@peff.net>,
	git@vger.kernel.org
Subject: Re: Bug report: .gitattributes: -diff Unset causes files to be reported as binaries
Date: Thu, 02 Jul 2009 13:29:30 +0200	[thread overview]
Message-ID: <4A4C9A1A.10206@gmail.com> (raw)
In-Reply-To: <200907021329.04258.fenglich@fastmail.fm>


>>> If -diff affects whether a file is treated as a binary, as opposed
>>> whether it's diff'ed, it would imo make sense to call it -binary.
>> No, diff affects how a file is diffed.  The particular setting "-diff"
>> diffs the file as if it was binary.
>
> Aha, then we're maybe at conclusion; if -diff doesn't cause the files to be
                                                 ^^^^^^^

???

> treated as binaries

Reread carefully.

1) There is no "-diff" attribute.  There is a "diff" attribute that 
affects *how* (not *whether*) files are diff.

2) A "-" in front of an attribute unsets the attribute.

3) The "diff" attribute, when unset, treats the file as binary.

ergo

4) Using "-diff" in .gitattributes treats the final as binary.

Paolo

  reply	other threads:[~2009-07-02 11:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 10:08 Bug report: .gitattributes: -diff Unset causes files to be reported as binaries Frans Englich
2009-07-02  5:35 ` Jeff King
2009-07-02  8:14   ` Frans Englich
2009-07-02 11:12     ` Paolo Bonzini
2009-07-02 11:29       ` Frans Englich
2009-07-02 11:29         ` Paolo Bonzini [this message]
2009-07-02 17:05       ` Jeff King
2009-07-02 11:59     ` Jakub Narebski
2009-07-02 17:04     ` Jeff King
2009-07-02 14:29 ` René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4C9A1A.10206@gmail.com \
    --to=paolo.bonzini@gmail.com \
    --cc=bonzini@gnu.org \
    --cc=fenglich@fastmail.fm \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.